Re: [ath6kl:pending 16/26] drivers/net/wireless/ath/wcn36xx/main.c:1091:23: warning: no previous prototype for 'wcn36xx_get_first_vif'

From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org, ath10k@lists.infradead.org
Subject: Re: [ath6kl:pending 16/26] drivers/net/wireless/ath/wcn36xx/main.c:1091:23: warning: no previous prototype for 'wcn36xx_get_first_vif'
Date: Sun, 23 May 2021 20:32:40 +0300	[thread overview]
Message-ID: <87im39gxtz.fsf@codeaurora.org> (raw)
In-Reply-To: <f4ed523d-b2c6-556f-b9a0-ae14b431645f@linaro.org> (Bryan O'Donoghue's message of "Sun, 23 May 2021 17:40:02 +0100")

Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> On 23/05/2021 14:05, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pending
>> head:   a9cccebc0c3b91c2e5d2033d11def1e6f7fc74d4
>> commit: d1f965c7b4068af9420408f308bcc6206158b658 [16/26] wcn36xx:
>> Run suspend for the first ieee80211_vif
>> config: arc-allyesconfig (attached as .config)
>> compiler: arceb-elf-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>          wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          #
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=d1f965c7b4068af9420408f308bcc6206158b658
>>          git remote add ath6kl
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
>>          git fetch --no-tags ath6kl pending
>>          git checkout d1f965c7b4068af9420408f308bcc6206158b658
>>          # save the attached .config to linux build tree
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/net/wireless/ath/wcn36xx/main.c:1091:23: warning: no
>>> previous prototype for 'wcn36xx_get_first_vif'
>>> [-Wmissing-prototypes]
>>      1091 | struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
>>           |                       ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +/wcn36xx_get_first_vif +1091 drivers/net/wireless/ath/wcn36xx/main.c
>>
>>    1090	
>>> 1091	struct ieee80211_vif *wcn36xx_get_first_vif(struct wcn36xx *wcn)
>>    1092	{
>>    1093		struct wcn36xx_vif *tmp;
>>    1094		struct ieee80211_vif *vif = NULL;
>>    1095	
>>    1096		list_for_each_entry(tmp, &wcn->vif_list, list) {
>>    1097			vif = wcn36xx_priv_to_vif(tmp);
>>    1098			if (vif)
>>    1099				break;
>>    1100		}
>>    1101		return vif;
>>    1102	}
>>    1103	
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>>
>
> Hi Kalle.
>
> I'll issue a fix for both of these ASAP

Oops, your patches were not supposed to be in the pending branch yet as
I saw some conflicts. I suspect my patchwork script has a bug with
handling conflicts.

Also I haven't had a chance to review your patches yet. So it would be
better if you can wait for my review comments, and after I have updated
ath.git master branch you can rebase them.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k