From: Kalle Valo <firstname.lastname@example.org> To: Bjorn Andersson <email@example.com> Cc: Amit Pundir <firstname.lastname@example.org>, Rob Herring <email@example.com>, Jeffrey Hugo <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, lkml <email@example.com>, ath10k <firstname.lastname@example.org>, Konrad Dybcio <email@example.com>, dt <firstname.lastname@example.org>, John Stultz <email@example.com>, Jakub Kicinski <firstname.lastname@example.org>, Sumit Semwal <email@example.com>, David S Miller <firstname.lastname@example.org> Subject: Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests Date: Mon, 07 Dec 2020 18:55:29 +0200 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20201124175146.GG185852@builder.lan> (Bjorn Andersson's message of "Tue, 24 Nov 2020 11:51:46 -0600") Bjorn Andersson <firstname.lastname@example.org> writes: > On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote: > >> Hi Rob, Bjorn, Kalle, >> >> On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson >> <email@example.com> wrote: >> > >> > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: >> > >> > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: >> > > > There are firmware versions which do not support host capability >> > > > QMI request. We suspect either the host cap is not implemented or >> > > > there may be firmware specific issues, but apparently there seem >> > > > to be a generation of firmware that has this particular behavior. >> > > > >> > > > For example, firmware build on Xiaomi Poco F1 (sdm845) phone: >> > > > "QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c3-00257-QCAHLSWMTPLZ-1" >> > > > >> > > > If we do not skip the host cap QMI request on Poco F1, then we >> > > > get a QMI_ERR_MALFORMED_MSG_V01 error message in the >> > > > ath10k_qmi_host_cap_send_sync(). But this error message is not >> > > > fatal to the firmware nor to the ath10k driver and we can still >> > > > bring up the WiFi services successfully if we just ignore it. >> > > > >> > > > Hence introducing this DeviceTree quirk to skip host capability >> > > > QMI request for the firmware versions which do not support this >> > > > feature. >> > > >> > > So if you change the WiFi firmware, you may force a DT change too. Those >> > > are pretty independent things otherwise. >> > > >> > >> > Yes and that's not good. But I looked at somehow derive this from >> > firmware version numbers etc and it's not working out, so I'm out of >> > ideas for alternatives. >> > >> > > Why can't you just always ignore this error? If you can't deal with this >> > > entirely in the driver, then it should be part of the WiFi firmware so >> > > it's always in sync. >> > > >> > >> > Unfortunately the firmware versions I've hit this problem on has gone >> > belly up when receiving this request, that's why I asked Amit to add a >> > flag to skip it. >> >> So what is next for this DT quirk? >> > > Rob, we still have this problem and we've not come up with any way to > determine in runtime that we need to skip this part of the > initialization. This is firmware version specific, right? There's also enum ath10k_fw_features which is embedded within firmware-N.bin, we could add a new flag there. But that means that a correct firmware-N.bin is needed for each firmware version, not sure if that would work out. Just throwing out ideas here. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list firstname.lastname@example.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-12-07 16:55 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-25 18:29 Amit Pundir 2020-09-26 0:00 ` Bjorn Andersson 2020-09-29 19:08 ` Rob Herring 2020-09-30 11:09 ` Amit Pundir 2020-10-29 13:40 ` Bjorn Andersson 2020-11-03 7:48 ` Amit Pundir 2020-11-24 17:51 ` Bjorn Andersson 2020-12-07 16:55 ` Kalle Valo [this message] 2021-02-02 11:11 ` Amit Pundir 2021-02-08 17:21 ` Kalle Valo 2021-02-08 17:48 ` Bjorn Andersson 2021-02-09 8:10 ` Kalle Valo 2021-05-20 11:47 ` Amit Pundir
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).