From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dG2Yo-0000Sh-GQ for ath10k@lists.infradead.org; Wed, 31 May 2017 12:17:12 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: add configurable debugging. Date: Wed, 31 May 2017 12:16:44 +0000 Message-ID: <87y3tdmdbo.fsf@kamboji.qca.qualcomm.com> References: <20170510211925.17468-1-adrian@freebsd.org> In-Reply-To: <20170510211925.17468-1-adrian@freebsd.org> (Adrian Chadd's message of "Wed, 10 May 2017 14:19:25 -0700") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Adrian Chadd Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Adrian Chadd writes: > This adds a few configurable debugging options: > > * driver debugging and tracing is now configurable per device > * driver debugging and tracing is now configurable at runtime > * the debugging / tracing is not run at all (besides a mask check) > unless the specific debugging bitmap field is configured. > > Signed-off-by: Adrian Chadd [...] > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -2444,6 +2444,8 @@ struct ath10k *ath10k_core_create(size_t priv_size, struct device *dev, > ar->hw_rev = hw_rev; > ar->hif.ops = hif_ops; > ar->hif.bus = bus; > + ar->debug_mask = ath10k_debug_mask; > + ar->trace_debug_mask = ath10k_debug_mask; Until now tracing has been always enabled, irrespective what debug_mask has contained. Now you are changing that and by default log messages are not delivered through tracing until user enables them. So I think to keep the old behaviour trace_debug_mask should be ATH10K_DBG_ANY (0xffffffff) by default and the user can modify the mask per device via the debugfs file. But is it really needed to be able to filter trace messages? debug_mask I understand, but not sure about trace_debug_mask. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k