From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: "Christian Marangi" <ansuelsmth@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Chris Snook" <chris.snook@gmail.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Jeroen de Borst" <jeroendb@google.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
"Shailend Chand" <shailend@google.com>,
"Douglas Miller" <dougmill@linux.ibm.com>,
"Nick Child" <nnac123@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Haren Myneni" <haren@linux.ibm.com>,
"Rick Lindsley" <ricklind@linux.ibm.com>,
"Dany Madden" <danymadden@us.ibm.com>,
"Thomas Falcon" <tlfalcon@linux.ibm.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Krzysztof Halasa" <khalasa@piap.pl>,
"Kalle Valo" <kvalo@kernel.org>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Chandrashekar Devegowda" <chandrashekar.devegowda@intel.com>,
"Intel Corporation" <linuxwwan@intel.com>,
"Chiranjeevi Rapolu" <chiranjeevi.rapolu@linux.intel.com>,
"Liu Haijun" <haijun.liu@mediatek.com>,
"M Chetan Kumar" <m.chetan.kumar@linux.intel.com>,
"Ricardo Martinez" <ricardo.martinez@linux.intel.com>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Sergey Ryazanov" <ryazanov.s.a@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Yuanjun Gong" <ruc_gongyuanjun@163.com>,
"Wei Fang" <wei.fang@nxp.com>, "Alex Elder" <elder@linaro.org>,
"Simon Horman" <horms@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bailey Forrest" <bcf@google.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Junfeng Guo" <junfeng.guo@intel.com>,
"Ziwei Xiao" <ziweixiao@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rushil Gupta" <rushilg@google.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Yuri Karpov" <YKarpov@ispras.ru>,
"Zhengchao Shao" <shaozhengchao@huawei.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Zheng Zengkai" <zhengzengkai@huawei.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Lee Jones" <lee@kernel.org>, "Dawei Li" <set_pte_at@outlook.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule
Date: Mon, 2 Oct 2023 09:08:14 -0700 [thread overview]
Message-ID: <9a65ff82-e6b0-4253-be86-a0962e673bc4@quicinc.com> (raw)
In-Reply-To: <20231002151023.4054-2-ansuelsmth@gmail.com>
On 10/2/2023 8:10 AM, Christian Marangi wrote:
> Change napi_schedule to return a bool on NAPI successful schedule. This
> might be useful for some driver to do additional step after a NAPI ahs
nit:s/ahs/has/
> been scheduled.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> include/linux/netdevice.h | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 7e520c14eb8c..2bead8e2a14d 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -490,11 +490,18 @@ bool napi_schedule_prep(struct napi_struct *n);
> *
> * Schedule NAPI poll routine to be called if it is not already
> * running.
> + * Return true if we schedule a NAPI or false if not.
> + * Refer to napi_schedule_prep() for additional reason on why
> + * a NAPI might not be scheduled.
> */
> -static inline void napi_schedule(struct napi_struct *n)
> +static inline bool napi_schedule(struct napi_struct *n)
> {
> - if (napi_schedule_prep(n))
> + if (napi_schedule_prep(n)) {
> __napi_schedule(n);
> + return true;
> + }
> +
> + return false;
> }
>
> /**
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2023-10-02 16:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 15:10 [net-next PATCH 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule Christian Marangi
2023-10-02 15:10 ` [net-next PATCH 2/4] netdev: make napi_schedule return bool on NAPI successful schedule Christian Marangi
2023-10-02 16:08 ` Jeff Johnson [this message]
2023-10-03 5:21 ` Eric Dumazet
2023-10-03 10:25 ` Christian Marangi
2023-10-02 15:10 ` [net-next PATCH 3/4] netdev: replace napi_reschedule with napi_schedule Christian Marangi
2023-10-02 16:12 ` Jeff Johnson
2023-10-02 21:41 ` Nick Child
2023-10-03 7:16 ` Marc Kleine-Budde
2023-10-03 11:18 ` Christian Marangi
2023-10-03 11:26 ` Marc Kleine-Budde
2023-10-02 15:10 ` [net-next PATCH 4/4] netdev: use napi_schedule bool instead of napi_schedule_prep/__napi_schedule Christian Marangi
2023-10-02 22:21 ` [net-next PATCH 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a65ff82-e6b0-4253-be86-a0962e673bc4@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=YKarpov@ispras.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=bcf@google.com \
--cc=benjamin.berg@intel.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=chris.snook@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=danymadden@us.ibm.com \
--cc=davem@davemloft.net \
--cc=dougmill@linux.ibm.com \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=gregory.greenman@intel.com \
--cc=gustavoars@kernel.org \
--cc=haijun.liu@mediatek.com \
--cc=haren@linux.ibm.com \
--cc=hdegoede@redhat.com \
--cc=horms@kernel.org \
--cc=jeroendb@google.com \
--cc=jgg@ziepe.ca \
--cc=joabreu@synopsys.com \
--cc=johannes@sipsolutions.net \
--cc=junfeng.guo@intel.com \
--cc=khalasa@piap.pl \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lee@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mkl@pengutronix.de \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=pkaligineedi@google.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajur@chelsio.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ricklind@linux.ibm.com \
--cc=robh@kernel.org \
--cc=ruc_gongyuanjun@163.com \
--cc=rushilg@google.com \
--cc=ryazanov.s.a@gmail.com \
--cc=set_pte_at@outlook.com \
--cc=shailend@google.com \
--cc=shaozhengchao@huawei.com \
--cc=tariqt@nvidia.com \
--cc=tglx@linutronix.de \
--cc=tlfalcon@linux.ibm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wei.fang@nxp.com \
--cc=wg@grandegger.com \
--cc=zhengzengkai@huawei.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).