From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C5BCC433EF for ; Mon, 9 May 2022 18:17:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w2KrxQyQbS6mdDov/3umZVsutH3m1T6lkxZ4zG2KrSo=; b=zgCAiVDjyWs/z0 //20Jj2JkvzCkzck8kwvxVFI7pZQpzqxn/9N39m91SfDCb9FdweokelxdLNJgQg8iW4DzGW5KzqlM hKpkIri4U0zcunLF+vEcOndspEHDSCQ6e5GZa2flo4kaU2dLlbjYA1IpLLrlDQ8gEJe61NCzoyAdZ jZy96NWF1MhPazngS1ptaLDmJaxqSg5AZr7mf2GKe+VIdVCYGun4deNfI1lBzSbzd1b6sU6fmJgE5 I4HVKzeflYhQPD9swIJXKvbB4BCvaFT6Z3HNLR1BCAntTxNAdjr7p2bQ/eew7SYwvdech4M5uy3Jp oOQPfwWz0MNkx4mWl87w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1no7wQ-00Fo7Q-K1; Mon, 09 May 2022 18:17:06 +0000 Received: from mail-ua1-x933.google.com ([2607:f8b0:4864:20::933]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1no7wN-00Fo3z-2A for ath10k@lists.infradead.org; Mon, 09 May 2022 18:17:04 +0000 Received: by mail-ua1-x933.google.com with SMTP id i16so5783834uat.5 for ; Mon, 09 May 2022 11:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CEWD095MTOxfk6m8EXeU/SEynd8zoPXbmNPb5cx6VuQ=; b=yFRVfUfbRFn1oqm8PM9R8gvlByUtyrnryPwjZZr9Mmza9c+/JOUHoEbVxImTSQldPS Vmjyl0CYzISDW164eQCf3kjn91i/O0V89uJVSBB1lk7hv7VBCpX0x47NPVT3kE9URxoI TiZWnEj6Qd247uEAl2KpfA3TrQnhNB6Y9VP1o4c3zxomXFrf77FKS9kdcpzXQor5eVKd Vepju0L3AW9dA75mRUnV7lRajkMVhMCAY1shjObVGi/pbB/BpKjypoxUIHuMHb6mPLlJ UZyxkcEjaaRvrrwalTcsezt1toWlWjFUaIeE87oDish+BEw6UGIo7CWNZlJ3teVLYejB Cq/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CEWD095MTOxfk6m8EXeU/SEynd8zoPXbmNPb5cx6VuQ=; b=G9XeejtTwXBl52I/M9bon3H60tgb81pcQDrRSQs8UCBOHNSEvFoPDeyoai3e98xax6 7H2Sad23Yt3SPHWixuvY77uZrXY3ayx3e1d7wwKh+gunP3dwVfDc2vxkWolMZpFayq8g YM9KbeykKio9NNapf9h5s9lC/okgmLbtjrjuxlIFSQEvN3gdf/jcFBRLbSJOd6rQimoS hdS0/vnDaXeJ3/ThZBHE0tbbc+fRz86yZT7at8PN6qd3jX3neP1cYNuIO6q1o15XQUlG yfVqEBGpIWChYw/LvPfF+5ev1/OiHzMC3GNPlstrFHiuPMwwEv7pJooCAbdECCzzE/cP bfyQ== X-Gm-Message-State: AOAM533loWXPBki7ecxF3SwE/IRFdOHIESoiUYcOZIokv2rY+zLZ9zDH sVE297j3FtR+MPcjB/7rFTqaVSI6Sbfoq9Vy7Sgk X-Google-Smtp-Source: ABdhPJwNvAMpqlS3sdklxAuAC6zwn8wlVqWIiEXGzvYdYIvDQRAl2UcE4uvhIBKD3Y/dAq6ICiiF8pgDhTQ+K3aQRvU= X-Received: by 2002:a05:6130:3a1:b0:365:84fa:2f57 with SMTP id az33-20020a05613003a100b0036584fa2f57mr10300866uab.62.1652120216817; Mon, 09 May 2022 11:16:56 -0700 (PDT) MIME-Version: 1.0 References: <20200527165718.129307-1-briannorris@chromium.org> In-Reply-To: From: Cale Collins Date: Mon, 9 May 2022 11:16:19 -0700 Message-ID: Subject: Re: [PATCH] Revert "ath: add support for special 0x0 regulatory domain" To: Brian Norris , Kalle Valo Cc: Patrick Steinhardt , ath10k , linux-wireless , Linux Kernel , stable , Tim Harvey , Stephen McCarthy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_111703_149022_1BACC9E5 X-CRM114-Status: GOOD ( 43.58 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org Hello Brian and Kalle, I'm experiencing an issue very similar to this. The regulatory domain settings wouldn't allow me to create an AP on 5ghz bands on kernels newer than 5.10 when using a WLE900VX (QCA9984) radio. I bisected the kernel and ultimately landed on the regression that Brian patched. I applied the patch and that resolved the issue from 5.4 up to 5.10. For versions later than that I encountered the same problem. I tried to bisect again but PCI is broken for the ARM board(s) I'm using in many of the RC's, I'm pretty new to all of this and it was just over my head. I saw Kalle pushed Brian's patch a few weeks ago, so I figured the politics behind how the regulatory domain should be addressed was decided at that point. I cherry picked Brian's patch onto 5.17 to test, the results are below. Can someone help me figure out what I can do to get 5ghz APs back? If there's any more information I can provide please let me know, I wanted to keep things on the shorter side. cale@cale:~/builds/upstream/linux$ git log --oneline 5c12efe9e783 (HEAD) Revert "ath: add support for special 0x0 regulatory domain" f443e374ae13 (tag: v5.17) Linux 5.17 #On my ARM64 board root@focal-ventana:~# uname -a Linux focal-ventana 5.17.0-00001-g5c12efe9e783 #1 SMP Wed Apr 6 16:33:54 PDT 2022 armv7l armv7l armv7l GNU/Linux root@focal-ventana:~# ls /sys/class/net/ can0 eth0 lo sit0 wlp6s0 root@focal-ventana:~# iw phy phy0 info | grep " MHz \[" | grep -v "no IR\|disabled" * 2412 MHz [1] (20.0 dBm) * 2417 MHz [2] (20.0 dBm) * 2422 MHz [3] (20.0 dBm) * 2427 MHz [4] (20.0 dBm) * 2432 MHz [5] (20.0 dBm) * 2437 MHz [6] (20.0 dBm) * 2442 MHz [7] (20.0 dBm) * 2447 MHz [8] (20.0 dBm) * 2452 MHz [9] (20.0 dBm) * 2457 MHz [10] (20.0 dBm) * 2462 MHz [11] (20.0 dBm) root@focal-ventana:~# iw reg get global country 00: DFS-UNSET (2402 - 2472 @ 40), (N/A, 20), (N/A) (2457 - 2482 @ 20), (N/A, 20), (N/A), AUTO-BW, NO-IR (2474 - 2494 @ 20), (N/A, 20), (N/A), NO-OFDM, NO-IR (5170 - 5250 @ 80), (N/A, 20), (N/A), AUTO-BW, NO-IR (5250 - 5330 @ 80), (N/A, 20), (0 ms), DFS, AUTO-BW, NO-IR (5490 - 5730 @ 160), (N/A, 20), (0 ms), DFS, NO-IR (5735 - 5835 @ 80), (N/A, 20), (N/A), NO-IR (57240 - 63720 @ 2160), (N/A, 0), (N/A) phy#0 country 99: DFS-UNSET (2402 - 2472 @ 40), (N/A, 20), (N/A) (5140 - 5360 @ 80), (N/A, 30), (N/A), PASSIVE-SCAN (5715 - 5860 @ 80), (N/A, 30), (N/A), PASSIVE-SCAN #dmesg |grep ath output [ 5.724215] ath10k_pci 0000:06:00.0: enabling device (0140 -> 0142) [ 5.732439] ath10k_pci 0000:06:00.0: pci irq msi oper_irq_mode 2 irq_mode 0 reset_mode 0 [ 17.573591] ath10k_pci 0000:06:00.0: qca988x hw2.0 target 0x4100016c chip_id 0x043202ff sub 0000:0000 [ 17.573707] ath10k_pci 0000:06:00.0: kconfig debug 0 debugfs 0 tracing 0 dfs 0 testmode 0 [ 17.575118] ath10k_pci 0000:06:00.0: firmware ver 10.2.4-1.0-00047 api 5 features no-p2p,raw-mode,mfp,allows-mesh-bcast crc32 35bd9258 [ 17.637397] ath10k_pci 0000:06:00.0: board_file api 1 bmi_id N/A crc32 bebc7c08 [ 18.849651] ath10k_pci 0000:06:00.0: htt-ver 2.1 wmi-op 5 htt-op 2 cal otp max-sta 128 raw 0 hwcrypto 1 Best regards, Cale Collins Cale Collins Field Applications Engineer II Gateworks Corporation (805)781-2000 x37 3026 S. Higuera, San Luis Obispo, CA 93401 www.gateworks.com On Mon, Apr 25, 2022 at 11:55 AM Brian Norris wrote: > > Hi Patrick, > > On Sat, Apr 23, 2022 at 3:52 AM Patrick Steinhardt wrote: > > This revert is in fact causing problems on my machine. I have a QCA9984, > > which exports two network interfaces. While I was able to still use one > > of both NICs for 2.4GHz, I couldn't really use the other card to set up > > a 5GHz AP anymore because all frequencies were restricted. This has > > started with v5.17.1, to which this revert was backported. > > > > Reverting this patch again fixes the issue on my system. So it seems > > like there still are cards out there in the wild which have a value of > > 0x0 as their regulatory domain. > > > > Quoting from your other mail: > > > > > My understanding was that no QCA modules *should* be shipped with a > > > value of 0 in this field. The instance I'm aware of was more or less a > > > manufacturing error I think, and we got Qualcomm to patch it over in > > > software. > > > > This sounds like the issue should've already been fixed in firmware, > > right? > > See the original patch: > https://git.kernel.org/linus/2dc016599cfa9672a147528ca26d70c3654a5423 > > "Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029." > > That patch was only tested for QCA6174 SDIO, and the 6174 firmware has > since been updated. So none of that really applies to QCA9984. I > suppose your device was also not working before v5.6 either, and IIUC, > according to Qualcomm your hardware is a manufacturing error (i.e., > invalid country code). > > I don't know what to tell you exactly, other than that the original > patch was wrong/unnecessary (and broke various existing systems) so it > should be reverted. I'm not quite sure how to fix the variety of > hardware out there (like yours) that may be using non-conforming > EEPROM settings. It would seem to me that we might need some more > targeted way of addressing broken hardware, rather than changing this > particular default workaround. I'm honestly not that familiar with > this Qualcomm regulatory stuff though, so my main contribution was > just to suggest reverting (i.e., don't break what used to work); I'm > not as savvy on providing alternative "fixes" for you. > > (That said: I *think* what's happening is that in the absence of a > proper EEPROM code, ath drivers fall back to a default=US country > code, and without further information to know you're compliant, > regulatory rules disallow initiating radiation (such as, an AP) on > 5GHz.) > > > I've added the relevant dmesg > > snippets though in case I'm mistaken: > > With what kernel? That looks like pre-v5.17.1. The "broken" > (post-5.17.1) logs might be a bit more informative. > > Sorry, > Brian _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k