From: "ojab //" <ojab@ojab.ru>
To: Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: ath10k@lists.infradead.org,
Linux Wireless <linux-wireless@vger.kernel.org>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ath10k: don't fail if IRAM write fails
Date: Wed, 25 Aug 2021 19:15:16 +0300 [thread overview]
Message-ID: <CAKzrAgRt0jRFyFNjF-uq=feG-9nhCx=tTztCgCEitj1cpMk_Xg@mail.gmail.com> (raw)
In-Reply-To: <20210722193459.7474-1-ojab@ojab.ru>
Can I haz it merged?
//wbr ojab
On Thu, 22 Jul 2021 at 22:36, ojab <ojab@ojab.ru> wrote:
>
> After reboot with kernel & firmware updates I found `failed to copy
> target iram contents:` in dmesg and missing wlan interfaces for both
> of my QCA9984 compex cards. Rolling back kernel/firmware didn't fixed
> it, so while I have no idea what's actually happening, I don't see why
> we should fail in this case, looks like some optional firmware ability
> that could be skipped.
>
> Also with additional logging there is
> ```
> [ 6.839858] ath10k_pci 0000:04:00.0: No hardware memory
> [ 6.841205] ath10k_pci 0000:04:00.0: failed to copy target iram contents: -12
> [ 6.873578] ath10k_pci 0000:07:00.0: No hardware memory
> [ 6.875052] ath10k_pci 0000:07:00.0: failed to copy target iram contents: -12
> ```
> so exact branch could be seen.
>
> Signed-off-by: Slava Kardakov <ojab@ojab.ru>
> ---
> Of course I forgot to sing off, since I don't use it by default because I
> hate my real name and kernel requires it
>
> drivers/net/wireless/ath/ath10k/core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 2f9be182fbfb..d9fd5294e142 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -2691,8 +2691,10 @@ static int ath10k_core_copy_target_iram(struct ath10k *ar)
> u32 len, remaining_len;
>
> hw_mem = ath10k_coredump_get_mem_layout(ar);
> - if (!hw_mem)
> + if (!hw_mem) {
> + ath10k_warn(ar, "No hardware memory");
> return -ENOMEM;
> + }
>
> for (i = 0; i < hw_mem->region_table.size; i++) {
> tmp = &hw_mem->region_table.regions[i];
> @@ -2702,8 +2704,10 @@ static int ath10k_core_copy_target_iram(struct ath10k *ar)
> }
> }
>
> - if (!mem_region)
> + if (!mem_region) {
> + ath10k_warn(ar, "No memory region");
> return -ENOMEM;
> + }
>
> for (i = 0; i < ar->wmi.num_mem_chunks; i++) {
> if (ar->wmi.mem_chunks[i].req_id ==
> @@ -2917,7 +2921,6 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode,
> if (status) {
> ath10k_warn(ar, "failed to copy target iram contents: %d",
> status);
> - goto err_hif_stop;
> }
> }
>
> --
> 2.32.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2021-08-25 16:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 19:35 [PATCH V2] ath10k: don't fail if IRAM write fails ojab
2021-07-22 19:42 ` ojab //
2021-08-02 2:23 ` Axel Rasmussen
2021-08-12 20:21 ` Axel Rasmussen
2021-08-14 11:33 ` sparks71
2021-08-25 16:15 ` ojab // [this message]
2021-09-08 23:42 ` ojab //
2021-09-17 19:30 ` ojab //
2021-09-18 10:12 ` sparks71
2021-09-18 11:21 ` ojab //
2021-09-21 7:29 ` Kalle Valo
2021-09-21 7:50 ` sparks71
2021-10-20 7:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKzrAgRt0jRFyFNjF-uq=feG-9nhCx=tTztCgCEitj1cpMk_Xg@mail.gmail.com' \
--to=ojab@ojab.ru \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).