ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] Add lockdep_assert_not_held()
@ 2021-02-12 23:28 Shuah Khan
  2021-02-12 23:28 ` [PATCH 1/2] lockdep: add lockdep_assert_not_held() Shuah Khan
  2021-02-12 23:28 ` [PATCH 2/2] ath10k: detect conf_mutex held ath10k_drain_tx() calls Shuah Khan
  0 siblings, 2 replies; 10+ messages in thread
From: Shuah Khan @ 2021-02-12 23:28 UTC (permalink / raw)
  To: peterz, mingo, will, kvalo, davem, kuba
  Cc: netdev, linux-wireless, linux-kernel, ath10k, Shuah Khan

Some kernel functions must not be called holding a specific lock. Doing
so could lead to locking problems. Currently these routines call
lock_is_held() to check for lock hold followed by WARN_ON.

Adding a common lockdep interface will help reduce the duplication of this
logic in the rest of the kernel.

Add lockdep_assert_not_held() to be used in these functions to detect
incorrect calls while holding a lock.

lockdep_assert_not_held() provides the opposite functionality of
lockdep_assert_held() which is used to assert calls that require
holding a specific lock.

The need for lockdep_assert_not_held() came up in a discussion on
ath10k patch. ath10k_drain_tx() and i915_vma_pin_ww() are examples
of functions that can use lockdep_assert_not_held().

Link: https://lore.kernel.org/linux-wireless/871rdmu9z9.fsf@codeaurora.org/

This patch series adds lockdep_assert_not_held() and uses it in the
second patch in ath10k_drain_tx() function.

Shuah Khan (2):
  lockdep: add lockdep_assert_not_held()
  ath10k: detect conf_mutex held ath10k_drain_tx() calls

 drivers/net/wireless/ath/ath10k/mac.c | 2 ++
 include/linux/lockdep.h               | 7 ++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

-- 
2.27.0


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-02-22 20:52 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 23:28 [PATCH 0/2] Add lockdep_assert_not_held() Shuah Khan
2021-02-12 23:28 ` [PATCH 1/2] lockdep: add lockdep_assert_not_held() Shuah Khan
2021-02-14 17:53   ` Peter Zijlstra
2021-02-15 10:44     ` Peter Zijlstra
2021-02-15 13:12       ` Johannes Berg
2021-02-15 16:04         ` Peter Zijlstra
2021-02-15 16:10           ` Johannes Berg
2021-02-22 20:51             ` Shuah Khan
2021-02-12 23:28 ` [PATCH 2/2] ath10k: detect conf_mutex held ath10k_drain_tx() calls Shuah Khan
2021-02-14  6:08   ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).