* Re: [PATCH v4 14/17] mac80211: support S1G association
[not found] ` <af51dd8e9dea2961546a502d9090d1a7@codeaurora.org>
@ 2020-11-23 8:39 ` Wen Gong
0 siblings, 0 replies; 4+ messages in thread
From: Wen Gong @ 2020-11-23 8:39 UTC (permalink / raw)
To: Thomas Pedersen; +Cc: Johannes Berg, linux-wireless, ath11k, ath10k
add more to know it.
On 2020-11-23 16:38, Wen Gong wrote:
> On 2020-09-22 10:28, Thomas Pedersen wrote:
> ...
>> @@ -3446,6 +3453,42 @@ bool ieee80211_chandef_he_6ghz_oper(struct
>> ieee80211_sub_if_data *sdata,
>>
>> *chandef = he_chandef;
>>
>> + return false;
>> +}
> This change the "return true" to "return false" by default of
> ieee80211_chandef_he_6ghz_oper.
> It should be typo mistake.
>> +
>> +bool ieee80211_chandef_s1g_oper(const struct ieee80211_s1g_oper_ie
>> *oper,
>> + struct cfg80211_chan_def *chandef)
>> +{
>> + u32 oper_freq;
>> +
>> + if (!oper)
>> + return false;
>> +
>> + switch (FIELD_GET(S1G_OPER_CH_WIDTH_OPER, oper->ch_width)) {
>> + case IEEE80211_S1G_CHANWIDTH_1MHZ:
>> + chandef->width = NL80211_CHAN_WIDTH_1;
>> + break;
>> + case IEEE80211_S1G_CHANWIDTH_2MHZ:
>> + chandef->width = NL80211_CHAN_WIDTH_2;
>> + break;
>> + case IEEE80211_S1G_CHANWIDTH_4MHZ:
>> + chandef->width = NL80211_CHAN_WIDTH_4;
>> + break;
>> + case IEEE80211_S1G_CHANWIDTH_8MHZ:
>> + chandef->width = NL80211_CHAN_WIDTH_8;
>> + break;
>> + case IEEE80211_S1G_CHANWIDTH_16MHZ:
>> + chandef->width = NL80211_CHAN_WIDTH_16;
>> + break;
>> + default:
>> + return false;
>> + }
>> +
>> + oper_freq = ieee80211_channel_to_freq_khz(oper->oper_ch,
>> + NL80211_BAND_S1GHZ);
>> + chandef->center_freq1 = KHZ_TO_MHZ(oper_freq);
>> + chandef->freq1_offset = oper_freq % 1000;
>> +
>> return true;
>> }
>>
> ....
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons
[not found] ` <20200922022818.15855-14-thomas@adapt-ip.com>
@ 2020-12-08 7:44 ` Wen Gong
2020-12-08 18:19 ` Thomas Pedersen
0 siblings, 1 reply; 4+ messages in thread
From: Wen Gong @ 2020-12-08 7:44 UTC (permalink / raw)
To: Thomas Pedersen; +Cc: Johannes Berg, linux-wireless, ath11k, ath10k
On 2020-09-22 10:28, Thomas Pedersen wrote:
> S1G beacons are 802.11 Extension Frames, so the fixed
> header part differs from regular beacons.
>
> Add a handler to process S1G beacons and abstract out the
> fetching of BSSID and element start locations in the
> beacon body handler.
>
> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
> ---
> net/mac80211/ieee80211_i.h | 4 ++
> net/mac80211/iface.c | 5 +++
> net/mac80211/mlme.c | 84 +++++++++++++++++++++++++++++---------
> net/mac80211/rx.c | 84 ++++++++++++++++----------------------
> net/mac80211/util.c | 52 +++++++++++++++++++++++
> 5 files changed, 162 insertions(+), 67 deletions(-)
>
...
> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct
> ieee80211_rx_data *rx)
> }
> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) {
> sta->rx_stats.last_rx = jiffies;
> - } else if (!is_multicast_ether_addr(hdr->addr1)) {
> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
> + is_multicast_ether_addr(hdr->addr1)) {
is this a typo mistake?
it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==>
is_multicast_ether_addr)
> /*
> * Mesh beacons will update last_rx when if they are found to
> * match the current local configuration when processed.
...
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons
2020-12-08 7:44 ` [PATCH v4 13/17] mac80211: receive and process S1G beacons Wen Gong
@ 2020-12-08 18:19 ` Thomas Pedersen
2020-12-09 2:48 ` Wen Gong
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Pedersen @ 2020-12-08 18:19 UTC (permalink / raw)
To: Wen Gong; +Cc: Johannes Berg, linux-wireless, ath11k, ath10k
Hi Wen,
On 2020-12-07 23:44, Wen Gong wrote:
> On 2020-09-22 10:28, Thomas Pedersen wrote:
>> S1G beacons are 802.11 Extension Frames, so the fixed
>> header part differs from regular beacons.
>>
>> Add a handler to process S1G beacons and abstract out the
>> fetching of BSSID and element start locations in the
>> beacon body handler.
>>
>> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
>> ---
>> net/mac80211/ieee80211_i.h | 4 ++
>> net/mac80211/iface.c | 5 +++
>> net/mac80211/mlme.c | 84
>> +++++++++++++++++++++++++++++---------
>> net/mac80211/rx.c | 84
>> ++++++++++++++++----------------------
>> net/mac80211/util.c | 52 +++++++++++++++++++++++
>> 5 files changed, 162 insertions(+), 67 deletions(-)
>>
> ...
>> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct
>> ieee80211_rx_data *rx)
>> }
>> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) {
>> sta->rx_stats.last_rx = jiffies;
>> - } else if (!is_multicast_ether_addr(hdr->addr1)) {
>> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
>> + is_multicast_ether_addr(hdr->addr1)) {
> is this a typo mistake?
> it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==>
> is_multicast_ether_addr)
Yes that does look like a typo, it should be:
} else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
!is_multicast_ether_addr(hdr->addr1)) {
(because is_multicast_ether_addr() evaluates to true for s1g beacons).
Do you have a patch or would you like me to send a fixup?
Thanks,
--
thomas
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4 13/17] mac80211: receive and process S1G beacons
2020-12-08 18:19 ` Thomas Pedersen
@ 2020-12-09 2:48 ` Wen Gong
0 siblings, 0 replies; 4+ messages in thread
From: Wen Gong @ 2020-12-09 2:48 UTC (permalink / raw)
To: Thomas Pedersen; +Cc: Johannes Berg, linux-wireless, ath11k, ath10k
On 2020-12-09 02:19, Thomas Pedersen wrote:
> Hi Wen,
>
> On 2020-12-07 23:44, Wen Gong wrote:
>> On 2020-09-22 10:28, Thomas Pedersen wrote:
>>> S1G beacons are 802.11 Extension Frames, so the fixed
>>> header part differs from regular beacons.
>>>
>>> Add a handler to process S1G beacons and abstract out the
>>> fetching of BSSID and element start locations in the
>>> beacon body handler.
>>>
>>> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
>>> ---
>>> net/mac80211/ieee80211_i.h | 4 ++
>>> net/mac80211/iface.c | 5 +++
>>> net/mac80211/mlme.c | 84
>>> +++++++++++++++++++++++++++++---------
>>> net/mac80211/rx.c | 84
>>> ++++++++++++++++----------------------
>>> net/mac80211/util.c | 52 +++++++++++++++++++++++
>>> 5 files changed, 162 insertions(+), 67 deletions(-)
>>>
>> ...
>>> @@ -1801,7 +1756,8 @@ ieee80211_rx_h_sta_process(struct
>>> ieee80211_rx_data *rx)
>>> }
>>> } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) {
>>> sta->rx_stats.last_rx = jiffies;
>>> - } else if (!is_multicast_ether_addr(hdr->addr1)) {
>>> + } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
>>> + is_multicast_ether_addr(hdr->addr1)) {
>> is this a typo mistake?
>> it removed ! for is_multicast_ether_addr(!is_multicast_ether_addr ==>
>> is_multicast_ether_addr)
>
> Yes that does look like a typo, it should be:
>
> } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
> !is_multicast_ether_addr(hdr->addr1)) {
>
> (because is_multicast_ether_addr() evaluates to true for s1g beacons).
>
> Do you have a patch or would you like me to send a fixup?
Yes, I have a patch for it.
I will send it.
>
> Thanks,
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-09 2:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200922022818.15855-1-thomas@adapt-ip.com>
[not found] ` <20200922022818.15855-15-thomas@adapt-ip.com>
[not found] ` <af51dd8e9dea2961546a502d9090d1a7@codeaurora.org>
2020-11-23 8:39 ` [PATCH v4 14/17] mac80211: support S1G association Wen Gong
[not found] ` <20200922022818.15855-14-thomas@adapt-ip.com>
2020-12-08 7:44 ` [PATCH v4 13/17] mac80211: receive and process S1G beacons Wen Gong
2020-12-08 18:19 ` Thomas Pedersen
2020-12-09 2:48 ` Wen Gong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).