From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
ath10k@lists.infradead.org, ath11k@lists.infradead.org,
ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org,
linux-arm-kernel@lists.infradead.org,
linux-bluetooth@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org,
linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper
Date: Thu, 12 Oct 2023 13:29:49 +0300 (EEST) [thread overview]
Message-ID: <bcecb577-bf69-e854-6f59-f4cb26c4b354@linux.intel.com> (raw)
In-Reply-To: <20231011193206.GA1039708@bhelgaas>
[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]
On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> On Mon, Sep 18, 2023 at 04:10:54PM +0300, Ilpo Järvinen wrote:
> > ASPM service driver does the same L0S / L1S / sub states allowed
> > calculation in __pci_disable_link_state() and
> > pci_set_default_link_state().
>
> Is there a typo or something here? This patch only adds a call to
> __pci_disable_link_state(), not to pci_set_default_link_state().
This was because one of the changes that got included in the meantime made
the state handling in those two functions to differ so I removed the call
from the code but forgot to update the changelog to match the code. I'll
fix the changelog.
--
i.
> > Create a helper to calculate the mask for the allowed states.
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> > drivers/pci/pcie/aspm.c | 33 +++++++++++++++++++++------------
> > 1 file changed, 21 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> > index ec6d7a092ac1..91dc95aca90f 100644
> > --- a/drivers/pci/pcie/aspm.c
> > +++ b/drivers/pci/pcie/aspm.c
> > @@ -1034,6 +1034,26 @@ static struct pcie_link_state *pcie_aspm_get_link(struct pci_dev *pdev)
> > return bridge->link_state;
> > }
> >
> > +static u8 pci_link_state_mask(int state)
> > +{
> > + u8 result = 0;
> > +
> > + if (state & PCIE_LINK_STATE_L0S)
> > + result |= ASPM_STATE_L0S;
> > + if (state & PCIE_LINK_STATE_L1)
> > + result |= ASPM_STATE_L1;
> > + if (state & PCIE_LINK_STATE_L1_1)
> > + result |= ASPM_STATE_L1_1;
> > + if (state & PCIE_LINK_STATE_L1_2)
> > + result |= ASPM_STATE_L1_2;
> > + if (state & PCIE_LINK_STATE_L1_1_PCIPM)
> > + result |= ASPM_STATE_L1_1_PCIPM;
> > + if (state & PCIE_LINK_STATE_L1_2_PCIPM)
> > + result |= ASPM_STATE_L1_2_PCIPM;
> > +
> > + return result;
> > +}
> > +
> > static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem)
> > {
> > struct pcie_link_state *link = pcie_aspm_get_link(pdev);
> > @@ -1063,18 +1083,7 @@ static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem)
> > if (sem)
> > down_read(&pci_bus_sem);
> > mutex_lock(&aspm_lock);
> > - if (state & PCIE_LINK_STATE_L0S)
> > - link->aspm_disable |= ASPM_STATE_L0S;
> > - if (state & PCIE_LINK_STATE_L1)
> > - link->aspm_disable |= ASPM_STATE_L1;
> > - if (state & PCIE_LINK_STATE_L1_1)
> > - link->aspm_disable |= ASPM_STATE_L1_1;
> > - if (state & PCIE_LINK_STATE_L1_2)
> > - link->aspm_disable |= ASPM_STATE_L1_2;
> > - if (state & PCIE_LINK_STATE_L1_1_PCIPM)
> > - link->aspm_disable |= ASPM_STATE_L1_1_PCIPM;
> > - if (state & PCIE_LINK_STATE_L1_2_PCIPM)
> > - link->aspm_disable |= ASPM_STATE_L1_2_PCIPM;
> > + link->aspm_disable |= pci_link_state_mask(state);
> > pcie_config_aspm_link(link, policy_to_aspm_state(link));
> >
> > if (state & PCIE_LINK_STATE_CLKPM)
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2023-10-12 10:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 13:10 [PATCH v2 00/13] PCI/ASPM: Make ASPM in core robust and remove driver workarounds Ilpo Järvinen
2023-09-18 13:10 ` [PATCH v2 01/13] PCI/ASPM: Rename pci_enable_link_state() to pci_set_default_link_state() Ilpo Järvinen
2023-09-18 13:10 ` [PATCH v2 02/13] PCI/ASPM: Improve pci_set_default_link_state() kerneldoc Ilpo Järvinen
2023-09-18 13:10 ` [PATCH v2 03/13] PCI/ASPM: Disable ASPM when driver requests it Ilpo Järvinen
2023-10-11 20:04 ` Bjorn Helgaas
2023-10-12 10:47 ` Ilpo Järvinen
2023-10-11 21:22 ` Bjorn Helgaas
2023-10-12 10:56 ` Ilpo Järvinen
2023-10-13 16:42 ` Bjorn Helgaas
2023-10-16 14:27 ` Ilpo Järvinen
2023-10-26 22:02 ` Bjorn Helgaas
2023-09-18 13:10 ` [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper Ilpo Järvinen
2023-10-11 19:32 ` Bjorn Helgaas
2023-10-12 10:29 ` Ilpo Järvinen [this message]
2023-09-18 13:10 ` [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() Ilpo Järvinen
2023-10-11 21:53 ` Bjorn Helgaas
2023-10-12 12:53 ` Ilpo Järvinen
2023-10-13 16:48 ` Bjorn Helgaas
2023-10-16 12:57 ` Ilpo Järvinen
2023-09-18 13:10 ` [PATCH v2 06/13] Bluetooth: hci_bcm4377: Convert aspm disable to quirk Ilpo Järvinen
2023-09-19 13:36 ` Sven Peter
2023-09-18 13:10 ` [PATCH v2 07/13] mt76: Remove unreliable pci_disable_link_state() workaround Ilpo Järvinen
2023-09-18 13:10 ` [PATCH v2 08/13] e1000e: Remove unreliable pci_disable_link_state{,_locked}() workaround Ilpo Järvinen
2023-09-18 13:10 ` [PATCH v2 09/13] wifi: ath10k: Use pci_disable/enable_link_state() Ilpo Järvinen
2023-09-19 9:39 ` Kalle Valo
2023-09-18 13:11 ` [PATCH v2 10/13] wifi: ath11k: " Ilpo Järvinen
2023-09-19 9:40 ` Kalle Valo
2023-09-18 13:11 ` [PATCH v2 11/13] wifi: ath12k: " Ilpo Järvinen
2023-09-19 9:40 ` Kalle Valo
2023-09-18 13:11 ` [PATCH v2 12/13] RDMA/hfi1: " Ilpo Järvinen
2023-09-18 13:11 ` [PATCH v2 13/13] misc: rtsx: " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcecb577-bf69-e854-6f59-f4cb26c4b354@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=bhelgaas@google.com \
--cc=emmanuel.grumbach@intel.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).