* Potential issue with htt flags
@ 2020-05-29 21:46 Ben Greear
0 siblings, 0 replies; only message in thread
From: Ben Greear @ 2020-05-29 21:46 UTC (permalink / raw)
To: ath10k
While porting forward my patches to 5.7 , I noticed this:
#define HTT_TX_CMPL_FLAG_DATA_RSSI BIT(0)
#define HTT_TX_CMPL_FLAG_PPID_PRESENT BIT(1)
#define HTT_TX_CMPL_FLAG_PA_PRESENT BIT(2)
#define HTT_TX_CMPL_FLAG_PPDU_DURATION_PRESENT BIT(3)
#define HTT_TX_DATA_RSSI_ENABLE_WCN3990 BIT(3)
#define HTT_TX_DATA_APPEND_RETRIES BIT(0)
#define HTT_TX_DATA_APPEND_TIMESTAMP BIT(1)
Both of these are used against 'flags2', but as you see, some bits are defined to different
things. In particular usage in,:
static int ath10k_get_htt_tx_data_rssi_pad(struct htt_resp *resp)
looks suspicious to me.
Maybe that ath10k_get_htt_tx_data_rssi_pad should be labeled specific for one particular
chipset?
I didn't look further, but maybe whoever added this could take a look?
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-29 21:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-29 21:46 Potential issue with htt flags Ben Greear
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).