From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56620C432BE for ; Fri, 27 Aug 2021 08:18:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2908460EE9 for ; Fri, 27 Aug 2021 08:18:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2908460EE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=noy9b20UBRUKSvPWtHlM3aBhynBC5BR13z6y/FJnbVE=; b=l/QDQRByixOospoDdz3T+RCkNV HLCWYQi4V3PSK+1bH9xe3wBIlvRl+nK0EERcX3l7P+Ixn9a+dSjANbKpKDY0jhHz1wXslgcpAhHv2 qWCCYWi9jl8haO7odcagh3+isfRmUFoptJMNrC2FnCKmxYwoz0s5bLchS+GFdgHoBohgEcZcBM01/ rDla1C2iLxT0i3GvUr/XdHcWlYWf05avv2eYelfaZQ1weuufnV6uTAkaSwfif70ToGD8qCtyhf4VB 1oOWJP9fS+JLgKImzwrb2z1aTdWpN9vbHrxKhOUsonIw0EW5T39gsj3cyeiVNPr9A6uOT+2JHHOxm 5XuvLITQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJX4O-00BwF5-AK; Fri, 27 Aug 2021 08:18:36 +0000 Received: from so254-9.mailgun.net ([198.61.254.9]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJX4J-00BwET-Hl for ath11k@lists.infradead.org; Fri, 27 Aug 2021 08:18:36 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1630052312; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=MAGYfx0QYX7S67RF9DlLdC59ix/pZDUbAAEsSRYUZeg=; b=f5biCszm6f36Eo/Luk7XeId+Y8WyjWqLFZy5s7KcYP5g2wW7Sqr5WwTXmRfzgaqc0dB4/pjL dPBdxk5u19tnq8yVn4tjAIAUZKqpsDvMoRjbMk1TFt1+TTOqrceO96xmcHj4CdZBng0PsRqM v+FPp5GV3bQx4B3bjzn8gTZnSkY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 61289fd4cd680e896970f5bd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 27 Aug 2021 08:18:28 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7E481C43460; Fri, 27 Aug 2021 08:18:27 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1CC53C4338F; Fri, 27 Aug 2021 08:18:27 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 27 Aug 2021 16:18:27 +0800 From: Wen Gong To: Johannes Berg Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 8/8] mac80211: save transmit power envelope element and power constraint In-Reply-To: <27680423e824dd67217cc6f1e62f9ac0a1af78f2.camel@sipsolutions.net> References: <20210820122041.12157-1-wgong@codeaurora.org> <20210820122041.12157-9-wgong@codeaurora.org> <25fcede26b99604a03d0b321b7120db4@codeaurora.org> <48ad47869e703cbef437378c508d6a5b64c160ae.camel@sipsolutions.net> <0680b508a7864e02f55d763851f7460baa73b53f.camel@sipsolutions.net> <110489059796b17849d0f32fb5189828@codeaurora.org> <27680423e824dd67217cc6f1e62f9ac0a1af78f2.camel@sipsolutions.net> Message-ID: <01d9e4eadbb0d87edbc026fc719858a3@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210827_011832_285997_66A31E16 X-CRM114-Status: GOOD ( 22.41 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 2021-08-27 15:38, Johannes Berg wrote: > On Fri, 2021-08-27 at 15:12 +0800, Wen Gong wrote: >> On 2021-08-27 14:55, Johannes Berg wrote: >> > On Fri, 2021-08-27 at 14:53 +0800, Wen Gong wrote: >> > > > >> > > > Well, there's an existing place in this function that uses >> > > > cfg80211_find_ext_ie(), and various uses of ieee80211_bss_get_ie(), so >> > > > it feels like if we're going to do the full parsing, we should switch >> > > > all the existing "look up an element" to also use the parsed data >> > > > instead. >> > >> > > ok. >> > > so it ha 2 way to change, right? >> > > 1. >> > > change ieee802_11_parse_elems() to ieee80211_bss_get_ie() >> > >> > No why? >> > >> > I think we should make a first patch (that doesn't add TPE yet) that >> > changes the function to ieee80211_parse_elems() and removes all the >> > ieee80211_bss_get_ie() / cfg80211_find_ext_ie() calls in favour of just >> > parsing once, and then looking at the elements there. >> > >> > Then your TPE patch becomes trivial since the elems are already there? >> this patch still needed, because the lower driver need the info. >> and this patch is save the info to "struct ieee80211_bss_conf >> *bss_conf" >> and >> pass it to lower driver. > > Of course, but you don't have to deal with parsing etc. in that patch > then. > yes. then should I use "struct ieee802_11_elems elems = {0}" or "struct ieee802_11_elems *elems = kzalloc(sizeof(*elems))" in the parsing patch? > johannes -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k