Re: [PATCH 1/2] wifi: ath11k: factory test mode support

From: Kalle Valo <kvalo@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Govindaraj Saminathan <quic_gsaminat@quicinc.com>,
	Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>,
	Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Subject: Re: [PATCH 1/2] wifi: ath11k: factory test mode support
Date: Mon, 27 Feb 2023 13:03:32 +0000 (UTC)	[thread overview]
Message-ID: <167750301098.30655.1426219945777543435.kvalo@kernel.org> (raw)
In-Reply-To: <20230213130854.2473-2-quic_rajkbhag@quicinc.com>

Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> wrote:

> Add support to process factory test mode commands(FTM) for calibration.
> By default firmware start with NORMAL mode and to process the FTM commands
> firmware needs to be restarted in FTM mode using module parameter ftm_mode.
> The pre-request is all the radios should be down before starting the test.
> 
> When start command ATH11K_TM_CMD_TESTMODE_START is received, ar state
> is set to Test Mode. If the FTM command or event length is greater
> than 256 bytes, it will be broken down into multiple segments and
> encoded with TLV header if it is segmented commands, else it is sent
> to firmware as it is.
> 
> On receiving UTF event from firmware, if it is segmented event, the driver
> will wait until it receives all the segments and notify the complete
> data to user application. In case the segmented sequence are missed or
> lost from the firmware, driver will skip the already received partial data.
> 
> In case of unsegmented UTF event from firmware, driver notifies the
> data to the user application as it comes. Applications handles
> the data further.
> 
> Command to boot in ftm mode
> insmod ath11k ftm_mode=1
> 
> Tested-on : IPQ8074 hw2.0 AHB WLAN.HK.2.7.0.1-01744-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Govindaraj Saminathan <quic_gsaminat@quicinc.com>
> Co-developed-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
> Signed-off-by: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

This had new warnings:

drivers/net/wireless/ath/ath11k/testmode.c:27:16: error: no previous prototype for 'ath11k_tm_get_ar' [-Werror=missing-prototypes]
drivers/net/wireless/ath/ath11k/testmode.h:26: void function return statements are not generally useful
drivers/net/wireless/ath/ath11k/core.c:1839: Blank lines aren't necessary before a close brace '}'

I fixed them in the pending branch, but please always use ath11k-check before submitting patches.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20230213130854.2473-2-quic_rajkbhag@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k