From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A65EC4361B for ; Thu, 17 Dec 2020 06:36:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23CB422D05 for ; Thu, 17 Dec 2020 06:36:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23CB422D05 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Date:Message-Id:To:References:In-Reply-To:From: Subject:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ufooOArqu0DSUWv5vFD0DX6iZalkuXrFkkAZUx5LewM=; b=p4hOgRWDVBib6A7jHjXxUGQ0u vhDZ22VdPmef5IyCvBo1O7h2XZ267JFgZ8BaB3wALyRO0wlslwtCvWIYqmOZyqbXuJhRMvEdLQ8mM bxfWud2lIu3w7TKY1LhYWzMGQ6x/4CJuIg34tlyvaW6LzsClleRk5AU2Sh5Oltupx8RrgtXW+iSOP z0oHt46msmusdYO6ExgPTimsOkdYKAQAl0kDPLImWvsDg4mmq/LRI0wGiR0EvpOrg27xHbN1divXW HMVoLq7rGo+ZqNNG4c3uLU916EhdyfK1oH0F6QhgenQN6oRedwxfl3t8zGCOOPrIiQMRUSNLiuND+ 8fbmn27aw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpmtS-0000mJ-Uf; Thu, 17 Dec 2020 06:36:07 +0000 Received: from m43-15.mailgun.net ([69.72.43.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpmtP-0000lg-Mv for ath11k@lists.infradead.org; Thu, 17 Dec 2020 06:36:05 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1608186962; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=T98ZymsfGkNAWJBzVsq/XoQMbTEjejDOaTahaJBxNK4=; b=gBxz603ceynbKsQZnA1Hb07Td700SGDBNiB2fyyMJq4QklQe7nyCRH1oJAjjI+JEXGDoLkTo kKBb4ZCLCJXCLJGnj0w2zlDYmHSfaQs505f2n1YI0/t1wJ1dL8KBYfrpAZlU48ajGPpcoLKK 5C3DlzQGzRoQy9mlTrI73tn7+H4= X-Mailgun-Sending-Ip: 69.72.43.15 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5fdafc510564dfefcdc9747e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 17 Dec 2020 06:36:01 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E5DB2C43461; Thu, 17 Dec 2020 06:36:00 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1AB14C433C6; Thu, 17 Dec 2020 06:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1AB14C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org MIME-Version: 1.0 Subject: Re: [PATCH][next] ath11k: add missing null check on allocated skb From: Kalle Valo In-Reply-To: <20201214232417.84556-1-colin.king@canonical.com> References: <20201214232417.84556-1-colin.king@canonical.com> To: Colin King User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201217063600.E5DB2C43461@smtp.codeaurora.org> Date: Thu, 17 Dec 2020 06:36:00 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201217_013603_803961_5A8C7FA9 X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, Carl Huang , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, Jakub Kicinski , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org Colin King wrote: > Currently the null check on a newly allocated skb is missing and > this can lead to a null pointer dereference is the allocation fails. > Fix this by adding a null check and returning -ENOMEM. > > Addresses-Coverity: ("Dereference null return") > Fixes: 43ed15e1ee01 ("ath11k: put hw to DBS using WMI_PDEV_SET_HW_MODE_CMDID") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. c86a36a621f2 ath11k: add missing null check on allocated skb -- https://patchwork.kernel.org/project/linux-wireless/patch/20201214232417.84556-1-colin.king@canonical.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k