From: Johannes Berg <johannes@sipsolutions.net>
To: Rameshkumar Sundaram <quic_ramess@quicinc.com>,
ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 3/3] wifi: ath11k: add support to enable/disable BSS color collision detection
Date: Wed, 15 Feb 2023 18:37:51 +0100 [thread overview]
Message-ID: <3dbd12c5c46b28c36504a0ebaf7d3b13bc2f141e.camel@sipsolutions.net> (raw)
In-Reply-To: <20230201065638.25990-4-quic_ramess@quicinc.com>
On Wed, 2023-02-01 at 12:26 +0530, Rameshkumar Sundaram wrote:
> Enable/Disable BSS color collision detection based on user
> configuration of collision detection and BSS color feature
> itself.
>
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com>
> ---
> drivers/net/wireless/ath/ath11k/mac.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> index 9e923ecb0891..6d5290996d9f 100644
> --- a/drivers/net/wireless/ath/ath11k/mac.c
> +++ b/drivers/net/wireless/ath/ath11k/mac.c
> @@ -3112,6 +3112,7 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
> u8 rateidx;
> u32 rate;
> u32 ipv4_cnt;
> + bool color_collision_detect;
>
> mutex_lock(&ar->conf_mutex);
>
> @@ -3370,10 +3371,12 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw *hw,
>
> if (changed & BSS_CHANGED_HE_BSS_COLOR) {
You never set this flag in the prior change, and it also doesn't even
*mean* the BSS color _detection_ changed ..??
johannes
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2023-02-15 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 6:56 [PATCH v3 0/3] wifi: Add support to enable/disable bss color collision detection Rameshkumar Sundaram
2023-02-01 6:56 ` [PATCH v3 1/3] wifi: cfg80211: add " Rameshkumar Sundaram
2023-02-15 17:34 ` Johannes Berg
2023-02-01 6:56 ` [PATCH v3 2/3] wifi: mac80211: Avoid BSS color collision detection if its disabled Rameshkumar Sundaram
2023-02-15 17:35 ` Johannes Berg
2023-02-15 17:37 ` Johannes Berg
2023-02-01 6:56 ` [PATCH v3 3/3] wifi: ath11k: add support to enable/disable BSS color collision detection Rameshkumar Sundaram
2023-02-15 17:37 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbd12c5c46b28c36504a0ebaf7d3b13bc2f141e.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_ramess@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).