From: bqiang@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Jouni Malinen <jouni@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] ath11k: Change number of TCL rings to one for QCA6390
Date: Wed, 29 Sep 2021 10:15:45 +0800 [thread overview]
Message-ID: <42fa097a799050100b6978ef0ab4e8b8@codeaurora.org> (raw)
In-Reply-To: <87tui4pwdz.fsf@codeaurora.org>
On 2021-09-28 23:12, Kalle Valo wrote:
> Jouni Malinen <jouni@codeaurora.org> writes:
>
>> From: Baochen Qiang <bqiang@codeaurora.org>
>>
>> Some targets, QCA6390 for example, use only one TCL ring,
>> it is better to initialize only one ring and leave others
>> untouched for such targets.
>>
>> Tested-on: QCA6390 hw2.0 PCI
>> WLAN.HST.1.0.1-01740-QCAHSTSWPLZ_V2_TO_X86-1
>>
>> Signed-off-by: Baochen Qiang <bqiang@codeaurora.org>
>> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
>
> It's better? Please be more specific. Does this fix a bug or is this
> just a theoretical fix you found during code review?
Yes, this is just a theoretical fix. By "better" I mean there is no need
to initialize
the other two TCL rings for QCA6390 since they are not used.
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-09-29 2:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 16:37 [PATCH 1/3] ath11k: Change number of TCL rings to one for QCA6390 Jouni Malinen
2021-09-14 16:37 ` [PATCH 2/3] ath11k: change return buffer manager " Jouni Malinen
2021-09-16 10:02 ` Kalle Valo
2021-09-28 15:09 ` Kalle Valo
2021-09-28 15:14 ` Kalle Valo
2021-09-29 2:42 ` bqiang
2021-10-01 6:26 ` Kalle Valo
2021-10-05 14:10 ` Kalle Valo
2021-10-25 13:02 ` Kalle Valo
2021-10-25 13:03 ` Kalle Valo
2021-09-14 16:37 ` [PATCH 3/3] ath11k: set correct NL80211_FEATURE_DYNAMIC_SMPS for WCN6855 Jouni Malinen
2021-09-16 10:08 ` Kalle Valo
2021-09-16 14:09 ` Wen Gong
2021-09-16 15:15 ` Kalle Valo
2021-10-28 10:07 ` Kalle Valo
2021-10-29 2:30 ` Wen Gong
2021-11-01 14:13 ` Kalle Valo
2021-09-28 15:12 ` [PATCH 1/3] ath11k: Change number of TCL rings to one for QCA6390 Kalle Valo
2021-09-29 2:15 ` bqiang [this message]
2021-10-05 14:06 ` Kalle Valo
2021-10-11 15:12 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42fa097a799050100b6978ef0ab4e8b8@codeaurora.org \
--to=bqiang@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).