* [PATCH] qrtr: mhi: Fix duplicate channel start
@ 2021-08-26 15:36 Loic Poulain
2021-08-26 16:34 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Loic Poulain @ 2021-08-26 15:36 UTC (permalink / raw)
To: kuba, kvalo, davem
Cc: netdev, ath11k, regressions, hemantk, nschichan,
manivannan.sadhasivam, Loic Poulain
commit ce78ffa3ef16 ("net: really fix the build...") handling a merge
conflict causes the mhi_prepare_for_transfer() function to be called
twice (with different flags), leading to QRTR probing issues.
Fixes: ce78ffa3ef16 ("net: really fix the build...")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
---
net/qrtr/mhi.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
index 1dc955c..deb8b03 100644
--- a/net/qrtr/mhi.c
+++ b/net/qrtr/mhi.c
@@ -83,11 +83,6 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
struct qrtr_mhi_dev *qdev;
int rc;
- /* start channels */
- rc = mhi_prepare_for_transfer(mhi_dev, 0);
- if (rc)
- return rc;
-
qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
if (!qdev)
return -ENOMEM;
--
2.7.4
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qrtr: mhi: Fix duplicate channel start
2021-08-26 15:36 [PATCH] qrtr: mhi: Fix duplicate channel start Loic Poulain
@ 2021-08-26 16:34 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-08-26 16:34 UTC (permalink / raw)
To: Loic Poulain
Cc: kuba, davem, netdev, ath11k, regressions, hemantk, nschichan,
manivannan.sadhasivam
Loic Poulain <loic.poulain@linaro.org> writes:
> commit ce78ffa3ef16 ("net: really fix the build...") handling a merge
> conflict causes the mhi_prepare_for_transfer() function to be called
> twice (with different flags), leading to QRTR probing issues.
>
> Fixes: ce78ffa3ef16 ("net: really fix the build...")
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Thanks for the patch, but with this patch the whole kernel crashes. I
tested on a NUC box with QCA6390 using v5.14-rc7. Unfortunately no
netconsole at the moment as I'm moving my workstations.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-26 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-26 15:36 [PATCH] qrtr: mhi: Fix duplicate channel start Loic Poulain
2021-08-26 16:34 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).