From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Berg Date: Mon, 22 Aug 2016 08:46:55 -0000 Subject: [ath9k-devel] ath9k: Fix beacon configuration assertion failure In-Reply-To: <87fuq1yt1x.fsf@kamboji.qca.qualcomm.com> References: <87fuq1yt1x.fsf@kamboji.qca.qualcomm.com> Message-ID: <1471855240.16921.6.camel@open-mesh.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote: > Actually, I see two patches which might be related but not identical: > > ath9k: fix client mode beacon configuration > https://patchwork.kernel.org/patch/9247699/ > > ath9k: Fix beacon configuration assertion failure > https://patchwork.kernel.org/patch/9281191/ > > Felix (CCed) & Benjamin: please take a look and advice which one I > should take. Yes, both patches are designed to fix the same issue in my patch. Felix solution looks entirely correct to me, the second solution seems slightly wrong because it prevents the call to ath9k_beacon_config from happening instead of ensuring the correct parameter value. ath9k_beacon_config needs to be called even if iter_data.beacons?is false as it disables the interrupts. Benjamin