From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Bj=C3=B8rn_Mork?= <bjorn@mork.no>
Date: Sun, 10 Jul 2016 00:32:42 -0000
Subject: [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device
	configuration from an OF node
In-Reply-To: <20160709232834.31654-4-martin.blumenstingl@googlemail.com>
	(Martin Blumenstingl's message of "Sun, 10 Jul 2016 01:28:34 +0200")
References: <20160624123430.4097-1-martin.blumenstingl@googlemail.com>
	<20160709232834.31654-1-martin.blumenstingl@googlemail.com>
	<20160709232834.31654-4-martin.blumenstingl@googlemail.com>
Message-ID: <87inwe9wfb.fsf@miraculix.mork.no>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:

> +	if (of_property_read_bool(np, "qca,clk-25mhz"))
> +		ah->is_clk_25mhz = true;
> +
> +	if (of_property_read_bool(np, "qca,disable-2ghz"))
> +		ah->disable_2ghz = true;
> +
> +	if (of_property_read_bool(np, "qca,disable-5ghz"))
> +		ah->disable_5ghz = true;

This is bike-shedding, but how about

	ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
	ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
	ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");

instead?


Bj?rn