From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Mon, 22 Aug 2016 18:43:54 +0300 Subject: [ath9k-devel] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues. In-Reply-To: <20160805160346.10545-1-toke@toke.dk> ("Toke \=\?utf-8\?Q\?H\?\= \=\?utf-8\?Q\?\=C3\=B8iland-J\=C3\=B8rgensen\=22's\?\= message of "Fri, 5 Aug 2016 18:03:46 +0200") References: <20160706193417.13080-1-toke@toke.dk> <20160805160346.10545-1-toke@toke.dk> Message-ID: <87mvk44xmt.fsf@purkki.adurom.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Toke H?iland-J?rgensen writes: > This switches ath9k over to using the mac80211 intermediate software > queueing mechanism for data packets. It removes the queueing inside the > driver, except for the retry queue, and instead pulls from mac80211 when > a packet is needed. The retry queue is used to store a packet that was > pulled but can't be sent immediately. > > The old code path in ath_tx_start that would queue packets has been > removed completely, as has the qlen limit tunables (since there's no > longer a queue in the driver to limit). > > Based on Tim's original patch set, but reworked quite thoroughly. > > Cc: Tim Shepard > Cc: Felix Fietkau > Signed-off-by: Toke H?iland-J?rgensen > --- > Changes since v3 (most due to Felix; thanks!): > - Correctly notify mac80211 when there are packets in the retry queue > on powersave start/stop. > - Get rid of ath_tx_aggr_resume(). > - Some readability changes and additional WARN_ON/BUG_ON in > appropriate places. This is great work but due to the regressions I'm not sure if this will be ready for 4.9. To get more testing time I wonder if we should wait for 4.10? IMHO applying this in the end of the cycle is too risky and we should try to maximise the time linux-next by applying this just after -rc1 is released. Thoughts? -- Kalle Valo