From: Kalle Valo <kvalo@codeaurora.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k: Fix beacon configuration assertion failure
Date: Mon, 22 Aug 2016 16:35:28 +0300 [thread overview]
Message-ID: <87r39h3p0f.fsf@purkki.adurom.net> (raw)
In-Reply-To: <1471855240.16921.6.camel@open-mesh.com> (Benjamin Berg's message of "Mon, 22 Aug 2016 10:40:40 +0200")
Benjamin Berg <benjamin.berg@open-mesh.com> writes:
> On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote:
>> Actually, I see two patches which might be related but not identical:
>>
>> ath9k: fix client mode beacon configuration
>> https://patchwork.kernel.org/patch/9247699/
>>
>> ath9k: Fix beacon configuration assertion failure
>> https://patchwork.kernel.org/patch/9281191/
>>
>> Felix (CCed) & Benjamin: please take a look and advice which one I
>> should take.
>
> Yes, both patches are designed to fix the same issue in my patch.
>
> Felix solution looks entirely correct to me, the second solution seems
> slightly wrong because it prevents the call to ath9k_beacon_config from
> happening instead of ensuring the correct parameter value.
> ath9k_beacon_config needs to be called even if iter_data.beacons?is
> false as it disables the interrupts.
Ok, I'll the patch from Felix then. Thanks.
--
Kalle Valo
next prev parent reply other threads:[~2016-08-22 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 15:17 [ath9k-devel] [PATCH] ath9k: Fix beacon configuration assertion failure Ioan-Adrian Ratiu
2016-08-19 9:13 ` [ath9k-devel] " Kalle Valo
2016-08-19 10:03 ` Kalle Valo
2016-08-19 11:01 ` Ioan-Adrian Ratiu
2016-08-22 8:46 ` Benjamin Berg
2016-08-22 13:35 ` Kalle Valo [this message]
2016-08-22 16:20 ` Ioan-Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r39h3p0f.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).