From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date: Sun, 10 Jul 2016 22:56:39 +0200
Subject: [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device
	configuration from an OF node
In-Reply-To: <87inwe9wfb.fsf@miraculix.mork.no>
References: <20160624123430.4097-1-martin.blumenstingl@googlemail.com>
	<20160709232834.31654-1-martin.blumenstingl@googlemail.com>
	<20160709232834.31654-4-martin.blumenstingl@googlemail.com>
	<87inwe9wfb.fsf@miraculix.mork.no>
Message-ID: <CAFBinCD0b9=o0B4_Orwe6uJfrbexr_Jf5JDctfRDmTnh3vPPug@mail.gmail.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On Sun, Jul 10, 2016 at 2:19 AM, Bj?rn Mork <bjorn@mork.no> wrote:
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>
>> +     if (of_property_read_bool(np, "qca,clk-25mhz"))
>> +             ah->is_clk_25mhz = true;
>> +
>> +     if (of_property_read_bool(np, "qca,disable-2ghz"))
>> +             ah->disable_2ghz = true;
>> +
>> +     if (of_property_read_bool(np, "qca,disable-5ghz"))
>> +             ah->disable_5ghz = true;
>
> This is bike-shedding, but how about
>
>         ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
>         ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
>         ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
I'm fine with either way - I'll simply adhere to the coding style that
the ath9k devs want to use, so just let me know which one you prefer.