All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] tpm: add support for partial reads
Date: Mon, 19 Nov 2018 08:44:49 -0800	[thread overview]
Message-ID: <b0efbbf8-6242-a48d-d984-b49d5fb20bb8@intel.com> (raw)
In-Reply-To: <20181119135800.GE8755@linux.intel.com>

On 11/19/18 5:58 AM, Jarkko Sakkinen wrote:
> Please explain a scenario where "!ret_size" would no work given that
> both size and partial_data have always positive value?

Right, I only looked at the one line above before responding.
I'll change it to !ret_size

> 
> I don't understand. In order to maintain backwards compatibility you can
> send a new command at any time.

No, currently it is not possible to send a new command until the previous
response is consumed. -EBUSY is returned if one sends a new command before
reading the previous response (or at least part of it). See:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/char/tpm/tpm-dev-common.c#n128

-- 
Tadeusz

  reply	other threads:[~2018-11-19 16:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 17:51 [PATCH 1/2] tpm: rename data_pending to transmit_result Tadeusz Struk
2018-11-16 17:51 ` [PATCH v4 2/2] tpm: add support for partial reads Tadeusz Struk
2018-11-18  7:48   ` Jarkko Sakkinen
2018-11-19  3:05     ` Tadeusz Struk
2018-11-19 13:58       ` Jarkko Sakkinen
2018-11-19 16:44         ` Tadeusz Struk [this message]
2018-11-19 17:28           ` Jarkko Sakkinen
2018-11-19 17:43             ` Tadeusz Struk
2018-11-18  7:41 ` [PATCH 1/2] tpm: rename data_pending to transmit_result Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0efbbf8-6242-a48d-d984-b49d5fb20bb8@intel.com \
    --to=tadeusz.struk@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.