All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Jaime Velasco Juan <jsagarribay@gmail.com>
Cc: dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] drm/radeon/kms: really wait for VBLANK in PM code
Date: Sun, 21 Feb 2010 00:04:45 +0100	[thread overview]
Message-ID: <b170af451002201504q53375f41x66728846aaf4be6f@mail.gmail.com> (raw)
In-Reply-To: <20100218180839.GA3386@pogo>

W dniu 18 lutego 2010 19:08 użytkownik Jaime Velasco Juan
<jsagarribay@gmail.com> napisał:
> El mié. 17 de feb. de 2010, a las 20:23:28 +0100, Rafał Miłecki escribió:
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> Reported-by: Jaime Velasco Juan <jsagarribay@gmail.com>
>> ---
>> This should make the trick, Jaime can you check if this works for you? Does it
>> kill your corruptions?
>
> It doesn't work, it have the same problem than the current code:
>
> [    8.682478] [drm] Requested: e: 68000 m: 80000 p: 16
> [    8.880126] [drm] Setting: e: 68000 m: 80000 p: 16
> [    9.280080] [drm] Requested: e: 30000 m: 40500 p: 16
> [    9.480118] [drm] Setting: e: 30000 m: 40500 p: 16
>
> What about the attached version, does it seem ok to you?. It seems to fix
> the corruptions for me.

Huh, your patch seems to do the same as my one. It just skips one
condition that should not matter.

It's hard to review without having corruptions myself, but today I
finally reproduced it! Using external HD TV (1920x1080) instead on my
panel (1600x900) and playing movie via Xv gives me massive
corruptions! Now I can really debug that! :)

-- 
Rafał

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

  reply	other threads:[~2010-02-20 23:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 19:23 [PATCH] drm/radeon/kms: really wait for VBLANK in PM code Rafał Miłecki
2010-02-18 18:08 ` Jaime Velasco Juan
2010-02-20 23:04   ` Rafał Miłecki [this message]
2010-02-20 23:50     ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b170af451002201504q53375f41x66728846aaf4be6f@mail.gmail.com \
    --to=zajec5@gmail.com \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=jsagarribay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.