From: Julien Grall <julien@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>, "Jan Beulich" <JBeulich@suse.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Ian Jackson" <Ian.Jackson@citrix.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] tools/libxl: Reposition build_pre() logic between architectures
Date: Mon, 30 Dec 2019 13:15:47 +0000 [thread overview]
Message-ID: <b190ca53-3541-438f-7a61-723a51e0d57d@xen.org> (raw)
In-Reply-To: <20191227134516.15530-1-andrew.cooper3@citrix.com>
Hi Andrew,
On 27/12/2019 13:45, Andrew Cooper wrote:
> The call to xc_domain_disable_migrate() is made only from x86, while its
> handling in Xen is common. Move it to the libxl__build_pre().
>
> hvm_set_conf_params(), hvm_set_viridian_features(),
> hvm_set_mca_capabilities(), and the altp2m logic is all in common
> code (parts ifdef'd) but despite this, is all actually x86 specific.
While altp2m is only supported on x86, the concept is not x86-specific.
I am actually aware of people using altp2m on Arm, althought the support
is not upstream yet.
>
> Move it into x86 specific code, and fold all of the xc_hvm_param_set() calls
> together into hvm_set_conf_params() in a far more coherent way.
>
> Finally - ensure that all hypercalls have their return values checked.
>
> No practical change in constructed domains. Fewer useless hypercalls now to
> construct an ARM guest.
I think it would be best to keep anything that we know can be used on
arm (or new architecture) in common code. I am thinking about
"nestedhvm" and "altp2m".
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-30 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 13:45 [Xen-devel] [PATCH] tools/libxl: Reposition build_pre() logic between architectures Andrew Cooper
2019-12-27 13:50 ` Jan Beulich
2019-12-30 12:56 ` Wei Liu
2019-12-30 12:50 ` Wei Liu
2019-12-30 13:15 ` Julien Grall [this message]
2019-12-30 13:38 ` Andrew Cooper
2019-12-30 13:45 ` Julien Grall
2020-01-02 17:40 ` Andrew Cooper
2020-01-03 10:52 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b190ca53-3541-438f-7a61-723a51e0d57d@xen.org \
--to=julien@xen.org \
--cc=Ian.Jackson@citrix.com \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.