Re: [PATCH wpan-next v2 3/6] ieee802154: Introduce a helper to validate a channel

From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Alexander Aring <alex.aring@gmail.com>,
	linux-wpan@vger.kernel.org
Cc: David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH wpan-next v2 3/6] ieee802154: Introduce a helper to validate a channel
Date: Tue, 3 Jan 2023 15:14:46 +0100	[thread overview]
Message-ID: <b1c095d1-6dee-b49d-52d4-a5ea84f36cfd@datenfreihafen.org> (raw)
In-Reply-To: <20221217000226.646767-4-miquel.raynal@bootlin.com>

Hello Miquel.

On 17.12.22 01:02, Miquel Raynal wrote:
> This helper for now only checks if the page member and channel member
> are valid (in the specification range) and supported (by checking the
> device capabilities). Soon two new parameters will be introduced and
> having this helper will let us only modify its content rather than
> modifying the logic everywhere else in the subsystem.
> 
> There is not functional change.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>   include/net/cfg802154.h   | 11 +++++++++++
>   net/ieee802154/nl802154.c |  3 +--
>   2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> index 76d4f95e9974..11bedfa96371 100644
> --- a/include/net/cfg802154.h
> +++ b/include/net/cfg802154.h
> @@ -246,6 +246,17 @@ static inline void wpan_phy_net_set(struct wpan_phy *wpan_phy, struct net *net)
>   	write_pnet(&wpan_phy->_net, net);
>   }
>   
> +static inline bool ieee802154_chan_is_valid(struct wpan_phy *phy,
> +                                            u8 page, u8 channel)
> +{
> +        if (page > IEEE802154_MAX_PAGE ||
> +            channel > IEEE802154_MAX_CHANNEL ||
> +            !(phy->supported.channels[page] & BIT(channel)))
> +                return false;
> +
> +	return true;
> +}
> +

This patch has some indent problems.

Commit 6bbb25ee282b ("ieee802154: Introduce a helper to validate a channel")
----------------------------------------------------------------------------
ERROR: code indent should use tabs where possible
#31: FILE: include/net/cfg802154.h:250:
+                                            u8 page, u8 channel)$

WARNING: please, no spaces at the start of a line
#31: FILE: include/net/cfg802154.h:250:
+                                            u8 page, u8 channel)$

ERROR: code indent should use tabs where possible
#33: FILE: include/net/cfg802154.h:252:
+        if (page > IEEE802154_MAX_PAGE ||$

WARNING: please, no spaces at the start of a line
#33: FILE: include/net/cfg802154.h:252:
+        if (page > IEEE802154_MAX_PAGE ||$

ERROR: code indent should use tabs where possible
#34: FILE: include/net/cfg802154.h:253:
+            channel > IEEE802154_MAX_CHANNEL ||$

WARNING: please, no spaces at the start of a line
#34: FILE: include/net/cfg802154.h:253:
+            channel > IEEE802154_MAX_CHANNEL ||$

ERROR: code indent should use tabs where possible
#35: FILE: include/net/cfg802154.h:254:
+            !(phy->supported.channels[page] & BIT(channel)))$

WARNING: please, no spaces at the start of a line
#35: FILE: include/net/cfg802154.h:254:
+            !(phy->supported.channels[page] & BIT(channel)))$

ERROR: code indent should use tabs where possible
#36: FILE: include/net/cfg802154.h:255:
+                return false;$

WARNING: please, no spaces at the start of a line
#36: FILE: include/net/cfg802154.h:255:
+                return false;$

total: 5 errors, 5 warnings, 0 checks, 26 lines checked

regards
Stefan Schmidt