From: Bart Van Assche <bvanassche@acm.org>
To: Arthur Simchaev <Arthur.Simchaev@wdc.com>, martin.petersen@oracle.com
Cc: beanhuo@micron.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] include: uapi: scsi: Change utp_upiu_query struct
Date: Wed, 22 Feb 2023 07:25:42 -0800 [thread overview]
Message-ID: <b1f0ed44-d707-5593-7449-8a6bd23c9902@acm.org> (raw)
In-Reply-To: <1677078770-30994-2-git-send-email-Arthur.Simchaev@wdc.com>
On 2/22/23 07:12, Arthur Simchaev wrote:
> diff --git a/include/uapi/scsi/scsi_bsg_ufs.h b/include/uapi/scsi/scsi_bsg_ufs.h
> index 2801b65..cccc07d 100644
> --- a/include/uapi/scsi/scsi_bsg_ufs.h
> +++ b/include/uapi/scsi/scsi_bsg_ufs.h
> @@ -54,20 +54,21 @@ struct utp_upiu_header {
> * @idn: a value that indicates the particular type of data B-1
> * @index: Index to further identify data B-2
> * @selector: Index to further identify data B-3
> - * @reserved_osf: spec reserved field B-4,5
> - * @length: number of descriptor bytes to read/write B-6,7
> - * @value: Attribute value to be written DW-5
> - * @reserved: spec reserved DW-6,7
> + * @osf4: spec field B-5
> + * @osf5: spec field B 6,7
> + * @osf6: spec field DW 8,9
> + * @osf7: spec field DW 10,11
> */
> struct utp_upiu_query {
> __u8 opcode;
> __u8 idn;
> __u8 index;
> __u8 selector;
> - __be16 reserved_osf;
> - __be16 length;
> - __be32 value;
> - __be32 reserved[2];
> + __u8 osf3;
> + __u8 osf4;
> + __be16 osf5;
> + __be32 osf6;
> + __be32 osf7;
> };
All changes in UAPI headers must be backwards compatible. The above
doesn't look like a backwards compatible change to me.
Bart.
next prev parent reply other threads:[~2023-02-22 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 15:12 [PATCH 0/2] ufs: core: Add support for qTimestamp attribute Arthur Simchaev
2023-02-22 15:12 ` [PATCH 1/2] include: uapi: scsi: Change utp_upiu_query struct Arthur Simchaev
2023-02-22 15:25 ` Bart Van Assche [this message]
2023-02-27 16:03 ` Arthur Simchaev
2023-02-27 16:59 ` Bart Van Assche
2023-03-01 9:46 ` Arthur Simchaev
2023-03-01 18:44 ` Bart Van Assche
2023-03-02 7:52 ` Arthur Simchaev
2023-02-23 2:23 ` kernel test robot
2023-02-22 15:12 ` [PATCH 2/2] ufs: core: Providing Timestamp information to the device Arthur Simchaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1f0ed44-d707-5593-7449-8a6bd23c9902@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.