From: Jens Axboe <axboe@kernel.dk>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC] iomap: only return IO error if no data has been transferred
Date: Wed, 18 Nov 2020 14:55:06 -0700 [thread overview]
Message-ID: <b218ddea-798c-b6a1-9039-e4279e6ce490@kernel.dk> (raw)
In-Reply-To: <20201118214805.GS7391@dread.disaster.area>
On 11/18/20 2:48 PM, Dave Chinner wrote:
> On Wed, Nov 18, 2020 at 02:36:47PM -0700, Jens Axboe wrote:
>> On 11/18/20 2:33 PM, Dave Chinner wrote:
>>> On Wed, Nov 18, 2020 at 02:19:30PM -0700, Jens Axboe wrote:
>>>>>>> Can you provide an actual event trace of the IOs in question that
>>>>>>> are failing in your tests (e.g. from something like `trace-cmd
>>>>>>> record -e xfs_file\* -e xfs_i\* -e xfs_\*write -e iomap\*` over the
>>>>>>> sequential that reproduces the issue) so that there's no ambiguity
>>>>>>> over how this problem is occurring in your systems?
>>>>>>
>>>>>> Let me know if you still want this!
>>>>>
>>>>> No, it makes sense now :)
>>>>
>>>> What's the next step here? Are you working on an XFS fix for this?
>>>
>>> I'm just building the patch now for testing.
>>
>> Nice, you're fast...
>
> Only when I understand exactly what is happening :/
That certainly helps...
> Patch below.
Thanks, ran it through the test case 20 times (would always fail before
in one run), and no issues observed.
Tested-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2020-11-18 21:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 22:17 [PATCH RFC] iomap: only return IO error if no data has been transferred Jens Axboe
2020-11-18 7:09 ` Christoph Hellwig
2020-11-18 7:19 ` Dave Chinner
2020-11-18 7:55 ` Dave Chinner
2020-11-18 15:26 ` Jens Axboe
2020-11-18 20:37 ` Dave Chinner
2020-11-18 21:00 ` Jens Axboe
2020-11-18 21:15 ` Dave Chinner
2020-11-18 21:19 ` Jens Axboe
2020-11-18 21:33 ` Dave Chinner
2020-11-18 21:36 ` Jens Axboe
2020-11-18 21:48 ` Dave Chinner
2020-11-18 21:55 ` Jens Axboe [this message]
2020-11-18 22:21 ` Dave Chinner
2020-11-26 14:00 ` [iomap] b258228a4e: Assertion_failed kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b218ddea-798c-b6a1-9039-e4279e6ce490@kernel.dk \
--to=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.