From: Jan Beulich <JBeulich@suse.com>
To: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
Cc: "george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"wl@xen.org" <wl@xen.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] x86/mm: Clean IOMMU flags from p2m-pt code
Date: Fri, 5 Jul 2019 15:37:40 +0000 [thread overview]
Message-ID: <b28e2003-59a6-2239-ff41-37ac0b894a0c@suse.com> (raw)
In-Reply-To: <b0bd291c-2408-5f64-446c-34abfaa3bf63@bitdefender.com>
On 05.07.2019 17:06, Alexandru Stefan ISAILA wrote:
>> On 03.07.2019 14:50, Alexandru Stefan ISAILA wrote:
>> And then I would of course have wished that a cleanup patch like this
>> one dealt with both sides, i.e. removed pt sharing remains from
>> xen/drivers/passthrough/amd/ at the same time (i.e. if not in one
>> patch, then at least in the same series). But this may again be just
>> me ...
>
> Just to clarify, are you talking about the amd_iommu_share_p2m()
> function that will not be called any more if the iommu_hap_pt_share flag
> will be deleted? If so I can add this in a 2 patch series.
That and there are a couple of iommu_use_hap_pt() uses that should
be deleted or have ASSERT_UNREACHABLE() added. I didn't check
further.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-07-05 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 12:50 [Xen-devel] [PATCH v2] x86/mm: Clean IOMMU flags from p2m-pt code Alexandru Stefan ISAILA
2019-07-05 14:42 ` Jan Beulich
2019-07-05 15:06 ` Alexandru Stefan ISAILA
2019-07-05 15:37 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b28e2003-59a6-2239-ff41-37ac0b894a0c@suse.com \
--to=jbeulich@suse.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.