From: Bob Pearson <rpearsonhpe@gmail.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org,
Bob Pearson <rpearson@hpe.com>
Subject: Re: [PATCH for-next] rdma_rxe: fixed bug in rxe_rcv_mcast_pkt
Date: Fri, 9 Oct 2020 12:02:38 -0500 [thread overview]
Message-ID: <b2bdcc9e-e882-259c-35da-f047a01a070d@gmail.com> (raw)
In-Reply-To: <20201008233305.GA422633@nvidia.com>
On 10/8/20 6:33 PM, Jason Gunthorpe wrote:
> On Thu, Oct 08, 2020 at 03:36:52PM -0500, Bob Pearson wrote:
>> - The changes referenced below replaced sbk_clone by
>> taking additional references, passing the skb along and
>> then freeing the skb. This deleted the packets before
>> they could be processed and additionally passed bad data
>> in each packet. Since pkt is stored in skb->cb
>> changing pkt->qp changed it for all the packets.
>> - Replace skb_get by sbk_clone in rxe_rcv_mcast_pkt for
>> cases where multiple QPs are receiving multicast packets
>> on the same address.
>> - Delete kfree_skb because the packets need to live until
>> they have been processed by each QP. They are freed later.
>>
>> Signed-off-by: Bob Pearson <rpearson@hpe.com>
>> Fixes: 86af61764151 ("IB/rxe: remove unnecessary skb_clone")
>> Fixes: fe896ceb5772 ("IB/rxe: replace refcount_inc with skb_get")
>
> Fixes lines go before the Signed-off-by
>
> Makes sense to me, applied to for-next
>
> Thanks,
> Jasno
>
Thanks.
prev parent reply other threads:[~2020-10-09 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 20:36 [PATCH for-next] rdma_rxe: fixed bug in rxe_rcv_mcast_pkt Bob Pearson
2020-10-08 23:33 ` Jason Gunthorpe
2020-10-09 17:02 ` Bob Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2bdcc9e-e882-259c-35da-f047a01a070d@gmail.com \
--to=rpearsonhpe@gmail.com \
--cc=jgg@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearson@hpe.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.