From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] xen: reset legacy rtc flag for PV domU
Date: Wed, 8 Sep 2021 10:54:07 -0400 [thread overview]
Message-ID: <b2cd2936-7ec4-e0b2-458e-51c12a3f56aa@oracle.com> (raw)
In-Reply-To: <20210903084937.19392-3-jgross@suse.com>
On 9/3/21 4:49 AM, Juergen Gross wrote:
> A Xen PV guest doesn't have a legacy RTC device, so reset the legacy
> RTC flag. Otherwise the following WARN splat will occur at boot:
>
> [ 1.333404] WARNING: CPU: 1 PID: 1 at /home/gross/linux/head/drivers/rtc/rtc-mc146818-lib.c:25 mc146818_get_time+0x1be/0x210
> [ 1.333404] Modules linked in:
> [ 1.333404] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G W 5.14.0-rc7-default+ #282
> [ 1.333404] RIP: e030:mc146818_get_time+0x1be/0x210
> [ 1.333404] Code: c0 64 01 c5 83 fd 45 89 6b 14 7f 06 83 c5 64 89 6b 14 41 83 ec 01 b8 02 00 00 00 44 89 63 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 30 0e ef 82 4c 89 e6 e8 71 2a 24 00 48 c7 c0 ff ff
> [ 1.333404] RSP: e02b:ffffc90040093df8 EFLAGS: 00010002
> [ 1.333404] RAX: 00000000000000ff RBX: ffffc90040093e34 RCX: 0000000000000000
> [ 1.333404] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 000000000000000d
> [ 1.333404] RBP: ffffffff82ef0e30 R08: ffff888005013e60 R09: 0000000000000000
> [ 1.333404] R10: ffffffff82373e9b R11: 0000000000033080 R12: 0000000000000200
> [ 1.333404] R13: 0000000000000000 R14: 0000000000000002 R15: ffffffff82cdc6d4
> [ 1.333404] FS: 0000000000000000(0000) GS:ffff88807d440000(0000) knlGS:0000000000000000
> [ 1.333404] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 1.333404] CR2: 0000000000000000 CR3: 000000000260a000 CR4: 0000000000050660
> [ 1.333404] Call Trace:
> [ 1.333404] ? wakeup_sources_sysfs_init+0x30/0x30
> [ 1.333404] ? rdinit_setup+0x2b/0x2b
> [ 1.333404] early_resume_init+0x23/0xa4
> [ 1.333404] ? cn_proc_init+0x36/0x36
> [ 1.333404] do_one_initcall+0x3e/0x200
> [ 1.333404] kernel_init_freeable+0x232/0x28e
> [ 1.333404] ? rest_init+0xd0/0xd0
> [ 1.333404] kernel_init+0x16/0x120
> [ 1.333404] ret_from_fork+0x1f/0x30
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Fixes: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs") ?
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2021-09-08 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 8:49 [PATCH 0/2] xen: fix illegal rtc device usage of pv guests Juergen Gross
2021-09-03 8:49 ` [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data Juergen Gross
2021-09-03 8:56 ` Greg Kroah-Hartman
2021-09-03 9:01 ` Juergen Gross
2021-09-03 9:08 ` Greg Kroah-Hartman
2021-09-06 17:07 ` Rafael J. Wysocki
2021-09-06 17:07 ` Rafael J. Wysocki
2021-09-07 4:18 ` Juergen Gross
2021-09-03 8:49 ` [PATCH 2/2] xen: reset legacy rtc flag for PV domU Juergen Gross
2021-09-08 14:54 ` Boris Ostrovsky [this message]
2021-09-10 7:27 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2cd2936-7ec4-e0b2-458e-51c12a3f56aa@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.