From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai1@huaweicloud.com>,
ming.lei@redhat.com, jack@suse.cz, hch@infradead.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: don't set GD_NEED_PART_SCAN if scan partition failed
Date: Thu, 6 Apr 2023 16:29:43 -0600 [thread overview]
Message-ID: <b3817e92-80ca-8eea-ebdd-f2172f3390c8@kernel.dk> (raw)
In-Reply-To: <42cfedca-f233-4d7e-f43b-4b5dd0c97e9e@huaweicloud.com>
On 4/5/23 9:42 PM, Yu Kuai wrote:
> Hi, Jens!
>
> 在 2023/03/22 11:59, Yu Kuai 写道:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> Currently if disk_scan_partitions() failed, GD_NEED_PART_SCAN will still
>> set, and partition scan will be proceed again when blkdev_get_by_dev()
>> is called. However, this will cause a problem that re-assemble partitioned
>> raid device will creat partition for underlying disk.
>>
>> Test procedure:
>>
>> mdadm -CR /dev/md0 -l 1 -n 2 /dev/sda /dev/sdb -e 1.0
>> sgdisk -n 0:0:+100MiB /dev/md0
>> blockdev --rereadpt /dev/sda
>> blockdev --rereadpt /dev/sdb
>> mdadm -S /dev/md0
>> mdadm -A /dev/md0 /dev/sda /dev/sdb
>>
>> Test result: underlying disk partition and raid partition can be
>> observed at the same time
>>
>> Note that this can still happen in come corner cases that
>> GD_NEED_PART_SCAN can be set for underlying disk while re-assemble raid
>> device.
>>
>
> Can you apply this patch?
None of them apply to my for-6.4/block branch...
--
Jens Axboe
next prev parent reply other threads:[~2023-04-06 22:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 2:21 [PATCH -next 0/2] block: fix scan partition for exclusively open device again Yu Kuai
2023-02-17 2:21 ` [PATCH -next 1/2] block: Revert "block: Do not reread partition table on exclusively open device" Yu Kuai
2023-02-17 11:01 ` Jan Kara
2023-02-17 2:22 ` [PATCH -next 2/2] block: fix scan partition for exclusively open device again Yu Kuai
2023-02-17 7:29 ` Christoph Hellwig
2023-02-17 11:05 ` Jan Kara
2023-02-17 13:16 ` [PATCH -next 0/2] " Jens Axboe
2023-03-21 11:43 ` Ming Lei
2023-03-22 1:26 ` Yu Kuai
2023-03-22 1:34 ` Ming Lei
2023-03-22 2:02 ` Yu Kuai
2023-03-22 2:15 ` Yu Kuai
2023-03-22 3:38 ` Ming Lei
2023-03-22 4:00 ` Yu Kuai
2023-03-22 3:59 ` [PATCH] block: don't set GD_NEED_PART_SCAN if scan partition failed Yu Kuai
2023-03-22 7:58 ` Ming Lei
2023-03-22 9:12 ` Yu Kuai
2023-03-22 9:47 ` Jan Kara
2023-03-22 11:34 ` Ming Lei
2023-03-22 13:07 ` Jan Kara
2023-03-22 16:08 ` Ming Lei
2023-03-23 10:51 ` Jan Kara
2023-03-23 12:03 ` Ming Lei
2023-03-22 9:52 ` Jan Kara
2023-03-23 23:59 ` Ming Lei
2023-04-06 3:42 ` Yu Kuai
2023-04-06 22:29 ` Jens Axboe [this message]
2023-04-07 2:01 ` Ming Lei
2023-04-07 2:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3817e92-80ca-8eea-ebdd-f2172f3390c8@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.