From: <Tudor.Ambarus@microchip.com>
To: <kamel.bouhara@bootlin.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v2] soc: at91: Add Atmel SFR SN (Serial Number) support
Date: Thu, 3 Oct 2019 09:50:44 +0000 [thread overview]
Message-ID: <b3e10d4c-4cdc-4401-a488-0b3d101d9ad0@microchip.com> (raw)
In-Reply-To: <8b8649d8-351b-8903-cb54-a56d7b6191df@microchip.com>
On 10/03/2019 12:40 PM, Tudor.Ambarus@microchip.com wrote:
cut
>
> how about renaming this to struct atmel_sfr_priv?
>
>> + struct device *dev;
>
> this is not used, maybe you can drop it?
>
>> + struct regmap *regmap;
>> + struct nvmem_config *config;
where is priv->config used?
>> + struct atmel_sfr_drvdata *drvdata;
>
> this is not used, maybe you can drop it?
>
>> +};
cut
>> +static struct atmel_sfr_drvdata sama5d2_sama5d4_drvdata = {
struct should be const. And I'm not sure about the sama5d2_sama5d4 naming. Maybe
choose "5d4_drvdata" and use it for 5d2 too? Maybe Nicolas has a preference here.
Thanks,
ta
>> + .nregs = 2 * 4,
>> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-03 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:16 [PATCH v2] soc: at91: Add Atmel SFR SN (Serial Number) support Kamel Bouhara
2019-10-03 9:40 ` Tudor.Ambarus
2019-10-03 9:50 ` Tudor.Ambarus [this message]
2019-10-03 12:06 ` Nicolas.Ferre
2019-10-03 12:10 ` Kamel Bouhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3e10d4c-4cdc-4401-a488-0b3d101d9ad0@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.