From: Kalle Valo <kvalo@codeaurora.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
linux-wireless <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
Zhen Lei <thunder.leizhen@huawei.com>
Subject: Re: [PATCH v2 1/1] b43: phy_n: Delete some useless TODO code
Date: Thu, 3 Jun 2021 09:31:03 +0000 (UTC) [thread overview]
Message-ID: <20210603093103.45E8FC43460@smtp.codeaurora.org> (raw)
In-Reply-To: <20210511034203.4122-2-thunder.leizhen@huawei.com>
Zhen Lei <thunder.leizhen@huawei.com> wrote:
> These TODO empty code are added by
> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
> been more than a decade now. I don't think anyone who wants to perfect
> this workaround can follow this TODO tip exactly. Instead, it limits them
> to new thinking. Remove it will be better.
>
> No functional change.
>
> By the way, this helps reduce some binary code size.
> Before:
> text data bss dec hex
> 74472 9967 0 84439 149d7
>
> After:
> text data bss dec hex
> 74408 9919 0 84327 14967
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
da16f5be45d0 b43: phy_n: Delete some useless TODO code
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210511034203.4122-2-thunder.leizhen@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
prev parent reply other threads:[~2021-06-03 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 3:42 [PATCH v2 0/1] b43: phy_n: Delete some useless TODO code Zhen Lei
2021-05-11 3:42 ` [PATCH v2 1/1] " Zhen Lei
2021-06-03 9:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603093103.45E8FC43460@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).