From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
To: Praghadeesh T K S <praghadeeshthevendria@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: praghadeeshtks@zohomail.in, skhan@linuxfoundation.org
Subject: Re: [PATCH] net: wireless/broadcom: fix possible condition with no effect
Date: Sun, 26 Jun 2022 13:03:57 +0200 [thread overview]
Message-ID: <458bd8dd-29c2-8029-20f5-f746db57740a@newmedia-net.de> (raw)
In-Reply-To: <20220625192902.30050-1-praghadeeshthevendria@gmail.com>
Am 25.06.2022 um 21:29 schrieb Praghadeesh T K S:
> Fix a coccinelle warning by removing condition with no possible effect
>
> Signed-off-by: Praghadeesh T K S <praghadeeshthevendria@gmail.com>
> ---
> drivers/net/wireless/broadcom/b43/xmit.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c
> index 7651b1b..667a74b 100644
> --- a/drivers/net/wireless/broadcom/b43/xmit.c
> +++ b/drivers/net/wireless/broadcom/b43/xmit.c
> @@ -169,12 +169,7 @@ static u16 b43_generate_tx_phy_ctl1(struct b43_wldev *dev, u8 bitrate)
> const struct b43_phy *phy = &dev->phy;
> const struct b43_tx_legacy_rate_phy_ctl_entry *e;
> u16 control = 0;
> - u16 bw;
> -
> - if (phy->type == B43_PHYTYPE_LP)
> - bw = B43_TXH_PHY1_BW_20;
> - else /* FIXME */
> - bw = B43_TXH_PHY1_BW_20;
> + u16 bw = B43_TXH_PHY1_BW_20;
Can you check if this is a possible register typo?
>
> if (0) { /* FIXME: MIMO */
> } else if (b43_is_cck_rate(bitrate) && phy->type != B43_PHYTYPE_LP) {
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
next prev parent reply other threads:[~2022-06-26 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 19:29 [PATCH] net: wireless/broadcom: fix possible condition with no effect Praghadeesh T K S
2022-06-26 11:03 ` Sebastian Gottschall [this message]
2022-06-26 11:12 ` Andrew Lunn
2022-06-26 11:18 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458bd8dd-29c2-8029-20f5-f746db57740a@newmedia-net.de \
--to=s.gottschall@newmedia-net.de \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praghadeeshthevendria@gmail.com \
--cc=praghadeeshtks@zohomail.in \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).