* [PATCH] b43legacy: remove unused freq_r3A_value function
@ 2023-03-24 13:50 Tom Rix
2023-03-24 16:50 ` Larry Finger
2023-03-31 14:50 ` wifi: " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-24 13:50 UTC (permalink / raw)
To: Larry.Finger, kvalo, davem, edumazet, kuba, pabeni, nathan, ndesaulniers
Cc: linux-wireless, b43-dev, netdev, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/net/wireless/broadcom/b43legacy/radio.c:1713:5: error:
unused function 'freq_r3A_value' [-Werror,-Wunused-function]
u16 freq_r3A_value(u16 frequency)
^
This function is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/wireless/broadcom/b43legacy/radio.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43legacy/radio.c b/drivers/net/wireless/broadcom/b43legacy/radio.c
index fdf78c10a05c..8d7eb89c1628 100644
--- a/drivers/net/wireless/broadcom/b43legacy/radio.c
+++ b/drivers/net/wireless/broadcom/b43legacy/radio.c
@@ -1709,23 +1709,6 @@ u16 b43legacy_radio_init2050(struct b43legacy_wldev *dev)
return ret;
}
-static inline
-u16 freq_r3A_value(u16 frequency)
-{
- u16 value;
-
- if (frequency < 5091)
- value = 0x0040;
- else if (frequency < 5321)
- value = 0x0000;
- else if (frequency < 5806)
- value = 0x0080;
- else
- value = 0x0040;
-
- return value;
-}
-
int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev,
u8 channel,
int synthetic_pu_workaround)
--
2.27.0
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] b43legacy: remove unused freq_r3A_value function
2023-03-24 13:50 [PATCH] b43legacy: remove unused freq_r3A_value function Tom Rix
@ 2023-03-24 16:50 ` Larry Finger
2023-03-31 14:50 ` wifi: " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Larry Finger @ 2023-03-24 16:50 UTC (permalink / raw)
To: Tom Rix, kvalo, davem, edumazet, kuba, pabeni, nathan, ndesaulniers
Cc: linux-wireless, b43-dev, netdev, linux-kernel, llvm
On 3/24/23 08:50, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/wireless/broadcom/b43legacy/radio.c:1713:5: error:
> unused function 'freq_r3A_value' [-Werror,-Wunused-function]
> u16 freq_r3A_value(u16 frequency)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix<trix@redhat.com>
> ---
> drivers/net/wireless/broadcom/b43legacy/radio.c | 17 -----------------
> 1 file changed, 17 deletions(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: b43legacy: remove unused freq_r3A_value function
2023-03-24 13:50 [PATCH] b43legacy: remove unused freq_r3A_value function Tom Rix
2023-03-24 16:50 ` Larry Finger
@ 2023-03-31 14:50 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-03-31 14:50 UTC (permalink / raw)
To: Tom Rix
Cc: Larry.Finger, davem, edumazet, kuba, pabeni, nathan,
ndesaulniers, linux-wireless, b43-dev, netdev, linux-kernel,
llvm, Tom Rix
Tom Rix <trix@redhat.com> wrote:
> clang with W=1 reports
> drivers/net/wireless/broadcom/b43legacy/radio.c:1713:5: error:
> unused function 'freq_r3A_value' [-Werror,-Wunused-function]
> u16 freq_r3A_value(u16 frequency)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Patch applied to wireless-next.git, thanks.
4c7f8c237d32 wifi: b43legacy: remove unused freq_r3A_value function
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230324135022.2649735-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 14:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 13:50 [PATCH] b43legacy: remove unused freq_r3A_value function Tom Rix
2023-03-24 16:50 ` Larry Finger
2023-03-31 14:50 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).