From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: "mcgrof@kernel.org" <mcgrof@kernel.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] module: Show the last unloaded module's taint flag(s)
Date: Tue, 28 Jun 2022 08:16:23 +0000 [thread overview]
Message-ID: <b44b2b4a-20e2-2d42-22b1-c1e44c6f999d@csgroup.eu> (raw)
In-Reply-To: <20220628074708.fg3ocx3vu7affkxl@ava.usersys.com>
Le 28/06/2022 à 09:47, Aaron Tomlin a écrit :
> On Tue 2022-06-28 05:54 +0000, Christophe Leroy wrote:
>>> - /* Store the name of the last unloaded module for diagnostic purposes */
>>> strlcpy(last_unloaded_module, mod->name, sizeof(last_unloaded_module));
>>> + strcat(last_unloaded_module, module_flags(mod, buf, false));
>>
>> You replace a bounded string copy by an unbounded strict contat.
>>
>> Should you use strlcat() instead ?
>
> Hi Christophe,
>
> Why? If I understand correctly, both the destination and source string are
> NULL-terminated (see module_flags()). So, strcat() should be sufficient.
>
Are you sure you will never ever end up with a string longer than the
length of last_unloaded_module ?
next prev parent reply other threads:[~2022-06-28 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 16:40 [PATCH 1/2] module: Modify module_flags() to accept show_state argument Aaron Tomlin
2022-06-27 16:40 ` [PATCH 2/2] module: Show the last unloaded module's taint flag(s) Aaron Tomlin
2022-06-28 5:54 ` Christophe Leroy
2022-06-28 7:47 ` Aaron Tomlin
2022-06-28 8:16 ` Christophe Leroy [this message]
2022-06-28 8:23 ` Aaron Tomlin
2022-07-03 14:22 ` Aaron Tomlin
2022-07-06 23:33 ` Luis Chamberlain
2022-07-06 23:37 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b44b2b4a-20e2-2d42-22b1-c1e44c6f999d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=atomlin@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.