From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, tiwai@suse.com,
vkoul@kernel.org, broonie@kernel.org,
Mateusz Gorski <mateusz.gorski@linux.intel.com>
Subject: Re: [PATCH 5/7] ASoC: Intel: skl_hda_dsp: Enable Dmic configuration
Date: Fri, 6 Mar 2020 09:49:50 -0600 [thread overview]
Message-ID: <b4874ca6-4c47-ffc8-f3b0-a2ba39797dcc@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2003061636580.2957@eliteleevi.tm.intel.com>
> But a more pressing issue is that this breaks platforms using SOF
> firmware:
>
> [ 28.751756] skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: no sink widget found for dmic01_hifi
> [ 28.751987] skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: Failed to add route DMIC01 Rx -> direct -> dmic01_hifi
>
> ... maybe you can align the topology to mathc so we can reuse the same
> widget mapping for both SOF and SST firmwares..?
Yeah, I thought this would break userspace and installed topologies and
that just confirms it. Adding hard-coded routes is really not recommended.
the alternate solution is what I suggested in another thread "No sound
since 5.4 on skl_n88l25_s4567", we could mark this machine driver as
having an incomplete topology and remove the topology checks in the core.
I couldn't really test my initial patch but that that Cezary
unintentionally broke SOF actually that gives me a tool to test the
solution.
next prev parent reply other threads:[~2020-03-06 15:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 14:53 [PATCH 0/7] ASoC: Intel: Skylake: Fix HDaudio and Dmic Cezary Rojewski
2020-03-05 14:53 ` [PATCH 1/7] ASoC: Intel: Skylake: Remove superfluous chip initialization Cezary Rojewski
2020-03-06 20:52 ` Pierre-Louis Bossart
2020-03-09 13:57 ` Cezary Rojewski
2020-03-09 16:48 ` Pierre-Louis Bossart
2020-03-09 17:43 ` Cezary Rojewski
2020-03-09 18:41 ` Pierre-Louis Bossart
2020-03-10 17:45 ` Applied "ASoC: Intel: Skylake: Remove superfluous chip initialization" to the asoc tree Mark Brown
2020-03-05 14:53 ` [PATCH 2/7] ASoC: Intel: Skylake: Select hda configuration permissively Cezary Rojewski
2020-03-06 20:57 ` Pierre-Louis Bossart
2020-03-09 13:47 ` Cezary Rojewski
2020-03-09 17:03 ` Pierre-Louis Bossart
2020-03-10 9:30 ` Cezary Rojewski
2020-03-10 17:45 ` Applied "ASoC: Intel: Skylake: Select hda configuration permissively" to the asoc tree Mark Brown
2020-03-05 14:53 ` [PATCH 3/7] ASoC: Intel: Skylake: Enable codec wakeup during chip init Cezary Rojewski
2020-03-10 17:44 ` Applied "ASoC: Intel: Skylake: Enable codec wakeup during chip init" to the asoc tree Mark Brown
2020-03-05 14:53 ` [PATCH 4/7] ASoC: Intel: Skylake: Shield against no-NHLT configurations Cezary Rojewski
2020-03-06 21:03 ` Pierre-Louis Bossart
2020-03-09 13:03 ` Cezary Rojewski
2020-03-09 17:01 ` Pierre-Louis Bossart
2020-03-09 17:38 ` Cezary Rojewski
2020-03-09 18:40 ` Pierre-Louis Bossart
2020-03-10 17:44 ` Applied "ASoC: Intel: Skylake: Shield against no-NHLT configurations" to the asoc tree Mark Brown
2020-03-05 14:53 ` [PATCH 5/7] ASoC: Intel: skl_hda_dsp: Enable Dmic configuration Cezary Rojewski
2020-03-06 14:46 ` Kai Vehmanen
2020-03-06 15:49 ` Pierre-Louis Bossart [this message]
2020-03-06 19:05 ` Cezary Rojewski
2020-03-06 19:49 ` Pierre-Louis Bossart
2020-03-06 19:58 ` Cezary Rojewski
2020-03-05 14:53 ` [PATCH 6/7] ASoC: Intel: Allow for ROM init retry on CNL platforms Cezary Rojewski
2020-03-10 17:44 ` Applied "ASoC: Intel: Allow for ROM init retry on CNL platforms" to the asoc tree Mark Brown
2020-03-05 14:53 ` [PATCH 7/7] ASoC: Intel: Skylake: Await purge request ack on CNL Cezary Rojewski
2020-03-10 17:44 ` Applied "ASoC: Intel: Skylake: Await purge request ack on CNL" to the asoc tree Mark Brown
2020-03-06 20:48 ` [PATCH 0/7] ASoC: Intel: Skylake: Fix HDaudio and Dmic Pierre-Louis Bossart
2020-03-09 11:38 ` Mark Brown
2020-03-09 14:02 ` Cezary Rojewski
2020-03-09 16:54 ` Mark Brown
2020-03-09 17:48 ` Cezary Rojewski
2020-03-09 17:52 ` Mark Brown
2020-03-10 16:03 ` Pierre-Louis Bossart
[not found] ` <2dc38392-760b-a5fc-fa00-98530729f2d3@intel.com>
2020-03-11 16:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4874ca6-4c47-ffc8-f3b0-a2ba39797dcc@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=mateusz.gorski@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.