From: Bart Van Assche <bvanassche@acm.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH v2 6/6] block, fs: Restore the per-bio/request data lifetime fields
Date: Mon, 5 Feb 2024 12:46:38 -0800 [thread overview]
Message-ID: <b545bbbf-06c5-4e32-aebe-769c639fea6c@acm.org> (raw)
In-Reply-To: <20240202203926.2478590-7-bvanassche@acm.org>
On 2/2/24 12:39, Bart Van Assche wrote:
> Restore support for passing data lifetime information from filesystems to
> block drivers. This patch reverts commit b179c98f7697 ("block: Remove
> request.write_hint") and commit c75e707fe1aa ("block: remove the
> per-bio/request write hint").
>
> This patch does not modify the size of struct bio because the new
> bi_write_hint member fills a hole in struct bio. pahole reports the
> following for struct bio on an x86_64 system with this patch applied:
>
> /* size: 112, cachelines: 2, members: 20 */
> /* sum members: 110, holes: 1, sum holes: 2 */
> /* last cacheline: 48 bytes */
Hi Jens,
Since this patch affects both the block layer and VFS code, can you please
help with reviewing this patch?
Thanks,
Bart.
next prev parent reply other threads:[~2024-02-05 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 20:39 [PATCH v2 0/6] Restore data lifetime support Bart Van Assche
2024-02-02 20:39 ` [PATCH v2 1/6] fs: Fix rw_hint validation Bart Van Assche
2024-02-02 20:39 ` [PATCH v2 2/6] fs: Verify write lifetime constants at compile time Bart Van Assche
2024-02-02 20:39 ` [PATCH v2 3/6] fs: Split fcntl_rw_hint() Bart Van Assche
2024-02-02 20:39 ` [PATCH v2 4/6] fs: Move enum rw_hint into a new header file Bart Van Assche
2024-02-02 20:39 ` [PATCH v2 5/6] fs: Propagate write hints to the struct block_device inode Bart Van Assche
2024-02-02 20:39 ` [PATCH v2 6/6] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2024-02-05 20:46 ` Bart Van Assche [this message]
2024-02-06 13:35 ` [PATCH v2 0/6] Restore data lifetime support Christian Brauner
2024-02-06 18:25 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b545bbbf-06c5-4e32-aebe-769c639fea6c@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.