From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>,
Jakub Matena <matenajakub@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH v3] selftest/vm: add mremap expand merge offset test
Date: Mon, 2 Jan 2023 17:20:49 +0100 [thread overview]
Message-ID: <b6b25373-ba6b-6610-1030-7f795f01987c@redhat.com> (raw)
In-Reply-To: <Y7MDVT4dO2pqxJwJ@lucifer>
On 02.01.23 17:16, Lorenzo Stoakes wrote:
> On Mon, Jan 02, 2023 at 05:10:40PM +0100, David Hildenbrand wrote:
>> Maybe wait until tomorrow for feedback from others. Make sure to include my
>> acked-by.
>
> Too late... I thought Andrew typically added these kind of things himself? As an
> Acked-by could be a reply to an unmodified patch for example. Though I guess
> it'd save you having to reply to the v4? Anyway sorry, already sent it!
Maintainers usually apply tags that are sent to the latest version, when
picking up the patch. Maintainers usually refrain from going through
multiple earlier patch versions to pick up tags -- especially, because
some changes might require a submitter from dropping tags (e.g., bigger
changes) and the tags might no longer be valid.
So better always include tags when resending, so they don't get lost.
>
> It's sat in the mailing list so others can review further if required, this is a
> bank holiday in the UK, and as a part-time contributor (and otherwise distracted
> by book work) it is a rare moment to be able to respond to feedback so will tend
> to get squashed into evenings/weekends/public holidays :) If people have further
> comments I will, of course, respond as + when I can!
>
> Cheers!
Happy holidays then :)
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-01-02 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:01 [PATCH v3] selftest/vm: add mremap expand merge offset test Lorenzo Stoakes
2023-01-02 16:03 ` David Hildenbrand
2023-01-02 16:09 ` Lorenzo Stoakes
2023-01-02 16:10 ` David Hildenbrand
2023-01-02 16:16 ` Lorenzo Stoakes
2023-01-02 16:20 ` David Hildenbrand [this message]
2023-01-02 16:22 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6b25373-ba6b-6610-1030-7f795f01987c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=matenajakub@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.