From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 2/2] xen/x86: hap: Clean-up and harden hap_enable()
Date: Tue, 4 Feb 2020 12:51:28 +0000 [thread overview]
Message-ID: <b789a1a7-b6be-c030-9155-5b05077c8c10@xen.org> (raw)
In-Reply-To: <7d2287d4-56a1-dcb9-38a3-31d8f66d050c@suse.com>
On 04/02/2020 12:36, Jan Beulich wrote:
> On 04.02.2020 12:44, Julien Grall wrote:
>> Aside the MISRA, there are some cases where I feel the explicit
>> comparisons make sense. But I don't have any rational for them and view
>> this as a matter of taste. So I would leave it to the author of the
>> patch the choice.
>
> FWIW, I disagree on this aspect. Consistency of the code base
> is, I think, more important an aspect. Yes, we likely never
> won't reach a fully consistent state, as goals shift, but
> anyway.
The meaning of consistency is quite broad. What you view as consistent
may not be for me (and vice versa). So we are down to the "matter of
taste" territory.
We could suggest to be consistent with the code surrounding, but I think
you will not be happy with it as some code does not suit the coding
style (see the recent discussion about using __).
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2020-02-04 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 9:34 [Xen-devel] [PATCH 0/2] xen/x86: hap: Small clean-up/hardening in hap_enable() Julien Grall
2020-02-04 9:34 ` [Xen-devel] [PATCH 1/2] xen/x86: hap: Fix coding style " Julien Grall
2020-02-04 10:07 ` Roger Pau Monné
2020-02-04 9:34 ` [Xen-devel] [PATCH 2/2] xen/x86: hap: Clean-up and harden hap_enable() Julien Grall
2020-02-04 10:51 ` Roger Pau Monné
2020-02-04 11:11 ` Julien Grall
2020-02-04 11:28 ` Roger Pau Monné
2020-02-04 11:33 ` George Dunlap
2020-02-04 11:44 ` Julien Grall
2020-02-04 12:36 ` Jan Beulich
2020-02-04 12:51 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b789a1a7-b6be-c030-9155-5b05077c8c10@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.