From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 5/6] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller
Date: Mon, 22 Feb 2021 18:23:15 +0100 [thread overview]
Message-ID: <b7f9872d-c346-4ffb-1463-2699dcaf0690@amsat.org> (raw)
In-Reply-To: <fa4f7bbb-3267-14a0-d20-c2a8836b79f4@eik.bme.hu>
On 2/22/21 6:01 PM, BALATON Zoltan wrote:
> On Mon, 22 Feb 2021, Philippe Mathieu-Daudé wrote:
>> On 2/22/21 4:22 PM, BALATON Zoltan wrote:
>>> The Marvell Discovery II aka. MV64361 is a PowerPC system controller
>>> chip that is used on the pegasos2 PPC board. This adds emulation of it
>>> that models the device enough to boot guests on this board. The
>>> mv643xx.h header with register definitions is taken from Linux 4.15.10
>>> only fixing end of line white space errors and removing not needed
>>> parts, it's otherwise keeps Linux formatting.
>>>
>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> ---
>>> hw/pci-host/Kconfig | 3 +
>>> hw/pci-host/meson.build | 2 +
>>> hw/pci-host/mv64361.c | 966 ++++++++++++++++++++++++++++++++++
>>> hw/pci-host/mv643xx.h | 919 ++++++++++++++++++++++++++++++++
>>> hw/pci-host/trace-events | 6 +
>>> include/hw/pci-host/mv64361.h | 8 +
>>> include/hw/pci/pci_ids.h | 1 +
>>> 7 files changed, 1905 insertions(+)
>>> create mode 100644 hw/pci-host/mv64361.c
>>> create mode 100644 hw/pci-host/mv643xx.h
>>> create mode 100644 include/hw/pci-host/mv64361.h
>>
>> Is this the datasheet for this controller?
>> ftp://ftp.freecalypso.org/PowerPC/support_ics/mv64360/datasheets/DS_64360_1_2.pdf.zip
>>
>>
>> It seems to have common parts with the GT64120.
>
> Yes, as noted on https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2
> the GT64120 seems to be an older (and MIPS specific) version of this
> chip that Marvell bought and likely made this PPC version based on that.
> (The whole pegasos2 seems to be like a MIPS board with a PPC CPU even
> down to the firmware which looks quite like PMON just has SmartFirmware
> instead of the commands of PMON. So whoever designed it, might have
> taken inspiration from some MIPS hardware.) However the emulation of
> GT64xxx in QEMU seemed to be not complete and different enough so I
> haven't looked at that when implementing this so I don't know how much
> commonality is there and if that would worth reusing. (If you think
> there could be some reuse then that should be done separate of this
> series, afterwards it's merged.)
Yes, I see your patch is more complete. Fair enough.
next prev parent reply other threads:[~2021-02-22 17:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 15:22 [PATCH v3 0/6] Pegasos2 emulation BALATON Zoltan
2021-02-22 15:22 ` [PATCH v3 6/6] hw/ppc: Add emulation of Genesi/bPlan Pegasos II BALATON Zoltan
2021-02-23 4:38 ` David Gibson
2021-02-22 15:22 ` [PATCH v3 1/6] vt82c686: Implement control of serial port io ranges via config regs BALATON Zoltan
2021-02-23 4:34 ` David Gibson
2021-02-23 9:18 ` BALATON Zoltan
2021-02-23 9:27 ` Philippe Mathieu-Daudé
2021-02-22 15:22 ` [PATCH v3 2/6] vt82c686: QOM-ify superio related functionality BALATON Zoltan
2021-02-22 15:22 ` [PATCH v3 4/6] vt82c686: Add emulation of VT8231 south bridge BALATON Zoltan
2021-02-22 15:22 ` [PATCH v3 3/6] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO BALATON Zoltan
2021-02-22 15:22 ` [PATCH v3 5/6] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller BALATON Zoltan
2021-02-22 16:40 ` Philippe Mathieu-Daudé
2021-02-22 17:01 ` BALATON Zoltan
2021-02-22 17:23 ` Philippe Mathieu-Daudé [this message]
2021-02-23 4:40 ` David Gibson
2021-02-23 9:13 ` BALATON Zoltan
2021-02-22 16:19 ` [PATCH v3 0/6] Pegasos2 emulation no-reply
2021-02-23 4:42 ` David Gibson
2021-02-23 9:24 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7f9872d-c346-4ffb-1463-2699dcaf0690@amsat.org \
--to=f4bug@amsat.org \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.