Re: [PATCH] HID: amd_sfh: Check that sensors are enabled before set/get report

From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"Natikar, Basavaraj" <Basavaraj.Natikar@amd.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
	Malte Starostik <malte@starostik.de>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Haochen Tong <linux@hexchain.org>
Subject: Re: [PATCH] HID: amd_sfh: Check that sensors are enabled before set/get report
Date: Thu, 6 Jul 2023 13:28:50 +0200	[thread overview]
Message-ID: <b81e3f5d-01ea-02c8-a9a7-e7f624ca0603@leemhuis.info> (raw)
In-Reply-To: <MN0PR12MB61012CD476072E6FBCCF5BE7E22FA@MN0PR12MB6101.namprd12.prod.outlook.com>

On 05.07.23 18:07, Limonciello, Mario wrote:
> [Public]
> 
>> can we check below patch series which solves this issue by initializing HID only
>> if is_any_sensor_enabled.
>> https://lore.kernel.org/all/nycvar.YFH.7.76.2305231559000.29760@cbobk.
>> fhfr.pm/
>>
> 
> The original reporter won't be able to test it because they've upgraded their
> firmware and SFH is disabled in the new firmware.
> 
> But yeah it seems plausible this series could help.  If it comes back up again
> we should point anyone affected to this series.
> 
> Thanks!

Hmmm. So this won't be fixed in 6.3.y. and 6.4.y then, as none of those
patches afaics looks like they will be picked up by the stable team?

Hmmm. That doesn't completely feel right to me, unless we consider the
problem Haochen Ton ran into an extremely unlikely bug (reminder: only a
few of those that encounter a problem will report it). Do we? If not: is
backporting that patch-set to 6.4.y an option once this was in mainline
for a while without causing trouble?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.