From: Johannes Berg <johannes@sipsolutions.net>
To: Nathan Chancellor <nathan@kernel.org>, gregory.greenman@intel.com
Cc: kvalo@kernel.org, ndesaulniers@google.com, trix@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH next] wifi: iwlwifi: Avoid disabling GCC specific flag with clang
Date: Thu, 16 Mar 2023 08:52:50 +0100 [thread overview]
Message-ID: <b9a4671bef0ad931a79c2911986286f1d9bb3ae9.camel@sipsolutions.net> (raw)
In-Reply-To: <20230315-iwlwifi-fix-pragma-v1-1-ad23f92c4739@kernel.org>
On Wed, 2023-03-15 at 20:28 -0700, Nathan Chancellor wrote:
> Clang errors:
>
> drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
> #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
> ^
> 1 error generated.
Oops.
> The warning being disabled by this pragma is GCC specific. Guard its use
> with CONFIG_CC_IS_GCC so that it is not used with clang to clear up the
> error.
>
Thanks.
johannes
prev parent reply other threads:[~2023-03-16 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 3:28 [PATCH next] wifi: iwlwifi: Avoid disabling GCC specific flag with clang Nathan Chancellor
2023-03-16 7:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9a4671bef0ad931a79c2911986286f1d9bb3ae9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=gregory.greenman@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.