Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros

From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Shuah Khan <shuah@kernel.org>, Shuah Khan <skhan@linuxfoundation.org>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
	kernel@collabora.com, Aishwarya TCV <aishwarya.tcv@arm.com>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] selftests: core: include linux/close_range.h for CLOSE_RANGE_* macros
Date: Tue, 23 Jan 2024 12:54:12 +0500	[thread overview]
Message-ID: <b9bccbc0-1f04-4d60-9a82-2688da82d436@collabora.com> (raw)
In-Reply-To: <20231024155137.219700-1-usama.anjum@collabora.com>

Hi,

Can anybody please pick this patch? This was fixing genuine regression in
some build system.

Thanks,

On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
> Correct header file is needed for getting CLOSE_RANGE_* macros.
> Previously it was tested with newer glibc which didn't show the need to
> include the header which was a mistake.
> 
> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  tools/testing/selftests/core/close_range_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
> index 534576f06df1c..c59e4adb905df 100644
> --- a/tools/testing/selftests/core/close_range_test.c
> +++ b/tools/testing/selftests/core/close_range_test.c
> @@ -12,6 +12,7 @@
>  #include <syscall.h>
>  #include <unistd.h>
>  #include <sys/resource.h>
> +#include <linux/close_range.h>
>  
>  #include "../kselftest_harness.h"
>  #include "../clone3/clone3_selftests.h"

-- 
BR,
Muhammad Usama Anjum