All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Keith Packard <keithp@keithp.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Clear any errors recorded before i915.ko is loaded
Date: Wed, 06 Apr 2011 07:52:27 +0100	[thread overview]
Message-ID: <b9dded$ijbm29@orsmga002.jf.intel.com> (raw)
In-Reply-To: <yunaag4mani.fsf@aiko.keithp.com>

On Tue, 05 Apr 2011 18:27:45 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Tue,  5 Apr 2011 23:00:46 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > This looks like it fixes two bugs:
> > 
> > 1) What if there is an error recorded before we start and so we
> > immediately service an IIR/EIR upon intalling the IRQ. Did we generate
> > that error during initialisation or was that SEP? Now we do stuff before
> > we even install the IRQ so there is a possibility that we zap one of our
> > own.
> 
> How will processing a pre-existing error condition cause trouble?

So that I can separate out bug reports that are caused by us during
initialisation from those that are caused by whatever was running before
us.

Considering the difficulty in working out what caused a PGTBL_ER during
initialisation, any reduction in the volume of noise is a good thing.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2011-04-06  6:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 22:00 [PATCH] drm/i915: Clear any errors recorded before i915.ko is loaded Chris Wilson
2011-04-06  1:27 ` Keith Packard
2011-04-06  6:52   ` Chris Wilson [this message]
2011-04-07  3:55     ` Keith Packard
2011-05-04 19:21 ` Keith Packard
2011-05-04 19:32   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='b9dded$ijbm29@orsmga002.jf.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.