Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Ido Schimmel <idosch@idosch.org>
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, lukasz.luba@arm.com,
	Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Amit Kucheria <amitk@kernel.org>,
	"open list:MELLANOX ETHERNET SWITCH DRIVERS"
	<netdev@vger.kernel.org>
Subject: Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name
Date: Sun, 14 Mar 2021 14:21:47 +0100	[thread overview]
Message-ID: <ba701ded-39e8-9e36-e828-a0ad14ba6caa@linaro.org> (raw)
In-Reply-To: <YE4FyiFgwM8cf5xe@shredder.lan>

On 14/03/2021 13:47, Ido Schimmel wrote:
> On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote:
>> We want to have any kind of name for the cooling devices as we do no
>> longer want to rely on auto-numbering. Let's replace the cooling
>> device's fixed array by a char pointer to be allocated dynamically
>> when registering the cooling device, so we don't limit the length of
>> the name.
>>
>> Rework the error path at the same time as we have to rollback the
>> allocations in case of error.
>>
>> Tested with a dummy device having the name:
>>  "Llanfairpwllgwyngyllgogerychwyrndrobwllllantysiliogogogoch"
>>
>> A village on the island of Anglesey (Wales), known to have the longest
>> name in Europe.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> 
> Tested-by: Ido Schimmel <idosch@nvidia.com>

Thanks !


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog