Re: [Intel-gfx] [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices

From: "Shankar, Uma" <uma.shankar@intel.com>
To: "Shankar, Uma" <uma.shankar@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices
Date: Tue, 1 Dec 2020 20:53:16 +0000	[thread overview]
Message-ID: <ba815f047c89464f88cf823b4b0e1646@intel.com> (raw)
In-Reply-To: <20201130204738.2443-1-uma.shankar@intel.com>

> -----Original Message-----
> From: Uma Shankar <uma.shankar@intel.com>
> Sent: Tuesday, December 1, 2020 2:17 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: ville.syrjala@linux.intel.com; Shankar, Uma <uma.shankar@intel.com>
> Subject: [v14 00/15] Enable HDR on MCA LSPCON based Gen9 devices
> 
> Gen9 hardware supports HDMI2.0 through LSPCON chips. Extending HDR support
> for MCA and Parade LSPCON based GEN9 devices.
> 
> SOC will drive LSPCON as DP and send HDR metadata as standard DP SDP packets.
> LSPCON will be set to operate in PCON mode, will receive the metadata and
> create Dynamic Range and Mastering Infoframe (DRM packets) and send it to
> HDR capable HDMI sink devices.
> 
> v2: Fixed Ville's review comments. Suppressed some warnings.
> Patch 8 of the series is marked "Not for Merge" and is just for reference to
> userspace people to incorporate in order to support 10bit content with 4K@60
> resolutions.
> 
> v3: Added Infoframe readout support for DRM infoframes.
> Addressed Jani Nikula's review comments.
> 
> v4: Addressed Ville's review comments and added proper bitmask for enabled
> infoframes. Series also incorporates Ville's patch for stopping infoframes to be
> sent to DVI sinks. Extended the same for DRM as well.
> 
> v5: Created separate helper function for lspcon_infoframes_enabled as per
> Ville's suggestion.
> 
> v6: Rebase
> 
> v7: Addressed Ville's review comments.
> 
> v8: Addressed Ville's review comments. Fixed the colorspace handling for Pcon
> and property attachment logic based on new lspcon detetction changes.
> 
> v9: Rebase
> 
> v10: Fixed one patch for detection
> 
> v11: Addressed Ville's review comments and added RB in the respective patches.
> 
> v12: Addressed Ville's review comments, re-order the changes. With Ville's help
> fixed the lingering colorspace handling for lspcon.
> 
> v13: 2 patches updated with feedback.
> 
> v14: Final series with all RB's in place, ready to merge.

Pushed to dinq.

Thanks Ville for all the help on this series.
Regards,
Uma Shankar

> Thanks Ville for all the suggestions and inputs.
> Note: Patch 15 of the series is for reference to userspace, not to be merged to
> driver.
> 
> Uma Shankar (14):
>   drm/i915/display: Add HDR Capability detection for LSPCON
>   drm/i915/display: Enable HDR on gen9 devices with MCA Lspcon
>   drm/i915/display: Attach HDR property for capable Gen9 devices
>   drm/i915/display: Fixes quantization range for YCbCr output
>   drm/i915/display: Add a WARN for invalid output range and format
>   drm/i915/display: Attach content type property for LSPCON
>   drm/i915/display: Enable colorspace programming for LSPCON devices
>   drm/i915/display: Nuke bogus lspcon check
>   drm/i915/display: Enable HDR for Parade based lspcon
>   drm/i915/lspcon: Create separate infoframe_enabled helper
>   drm/i915/display: Implement infoframes readback for LSPCON
>   drm/i915/display: Implement DRM infoframe read for LSPCON
>   drm/i915/lspcon: Do not send DRM infoframes to non-HDMI sinks
>   drm/i915/display: [NOT FOR MERGE] Reduce blanking to support
>     4k60@10bpp for LSPCON
> 
> Ville Syrjälä (1):
>   drm/i915: Split intel_attach_colorspace_property() into HDMI vs. DP
>     variants
> 
>  .../gpu/drm/i915/display/intel_connector.c    |  29 ++--
>  .../gpu/drm/i915/display/intel_connector.h    |   3 +-
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  16 +-
>  .../drm/i915/display/intel_display_types.h    |   1 +
>  drivers/gpu/drm/i915/display/intel_dp.c       |  43 ++++-
>  drivers/gpu/drm/i915/display/intel_hdmi.c     |  26 +--
>  drivers/gpu/drm/i915/display/intel_lspcon.c   | 162 +++++++++++++++---
>  drivers/gpu/drm/i915/display/intel_lspcon.h   |  12 ++
>  8 files changed, 227 insertions(+), 65 deletions(-)
> 
> --
> 2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx