From: "Durrant, Paul" <xadimgnik@gmail.com>
To: Jan Beulich <jbeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH v8 6/6] AMD/IOMMU: expose errors and warnings unconditionally
Date: Tue, 28 Sep 2021 08:42:44 +0100 [thread overview]
Message-ID: <ba9fe216-32a8-ef6d-173b-4f0d31a20db2@gmail.com> (raw)
In-Reply-To: <dc0cd7f7-a313-099d-3e89-e3862ed11f43@suse.com>
On 22/09/2021 15:38, Jan Beulich wrote:
> Making these dependent upon "iommu=debug" isn't really helpful in the
> field. Where touching respective code anyway also make use of %pp and
> %pd.
>
> Requested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul@xen.org>
... with one nit below...
> ---
[snip]
> --- a/xen/drivers/passthrough/amd/iommu_acpi.c
> +++ b/xen/drivers/passthrough/amd/iommu_acpi.c
> @@ -174,7 +174,7 @@ static int __init reserve_unity_map_for_
> if ( unity_map->addr + unity_map->length > base &&
> base + length > unity_map->addr )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: overlap [%lx,%lx) vs [%lx,%lx)\n",
> + AMD_IOMMU_ERROR("IVMD: overlap [%lx,%lx) vs [%lx,%lx)\n",
> base, base + length, unity_map->addr,
> unity_map->addr + unity_map->length);
> return -EPERM;
> @@ -248,7 +248,7 @@ static int __init register_range_for_dev
> iommu = find_iommu_for_device(seg, bdf);
> if ( !iommu )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: No IOMMU for Dev_Id %#x!\n", bdf);
> + AMD_IOMMU_ERROR("IVMD: no IOMMU for Dev_Id %#x\n", bdf);
> return -ENODEV;
> }
> req = ivrs_mappings[bdf].dte_requestor_id;
> @@ -318,7 +318,7 @@ static int __init parse_ivmd_device_sele
> bdf = ivmd_block->header.device_id;
> if ( bdf >= ivrs_bdf_entries )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: Invalid Dev_Id %#x\n", bdf);
> + AMD_IOMMU_ERROR("IVMD: invalid Dev_Id %#x\n", bdf);
> return -ENODEV;
> }
>
> @@ -335,16 +335,14 @@ static int __init parse_ivmd_device_rang
> first_bdf = ivmd_block->header.device_id;
> if ( first_bdf >= ivrs_bdf_entries )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: "
> - "Invalid Range_First Dev_Id %#x\n", first_bdf);
> + AMD_IOMMU_ERROR("IVMD: invalid Range_First Dev_Id %#x\n", first_bdf);
> return -ENODEV;
> }
>
> last_bdf = ivmd_block->aux_data;
> if ( (last_bdf >= ivrs_bdf_entries) || (last_bdf <= first_bdf) )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: "
> - "Invalid Range_Last Dev_Id %#x\n", last_bdf);
> + AMD_IOMMU_ERROR("IVMD: invalid Range_Last Dev_Id %#x\n", last_bdf);
> return -ENODEV;
> }
>
> @@ -367,7 +365,7 @@ static int __init parse_ivmd_device_iomm
> ivmd_block->aux_data);
> if ( !iommu )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: No IOMMU for Dev_Id %#x Cap %#x\n",
> + AMD_IOMMU_ERROR("IVMD: no IOMMU for Dev_Id %#x Cap %#x\n",
> ivmd_block->header.device_id, ivmd_block->aux_data);
> return -ENODEV;
> }
> @@ -384,7 +382,7 @@ static int __init parse_ivmd_block(const
>
> if ( ivmd_block->header.length < sizeof(*ivmd_block) )
> {
> - AMD_IOMMU_DEBUG("IVMD Error: Invalid Block Length!\n");
> + AMD_IOMMU_ERROR("IVMD: invalid block length\n");
> return -ENODEV;
> }
>
> @@ -402,8 +400,8 @@ static int __init parse_ivmd_block(const
> (addr_bits < BITS_PER_LONG &&
> ((start_addr + mem_length - 1) >> addr_bits)) )
> {
> - AMD_IOMMU_DEBUG("IVMD: [%lx,%lx) is not IOMMU addressable\n",
> - start_addr, start_addr + mem_length);
> + AMD_IOMMU_WARN("IVMD: [%lx,%lx) is not IOMMU addressable\n",
> + start_addr, start_addr + mem_length);
> return 0;
> }
>
> @@ -411,8 +409,8 @@ static int __init parse_ivmd_block(const
> {
> paddr_t addr;
>
> - AMD_IOMMU_DEBUG("IVMD: [%lx,%lx) is not (entirely) in reserved memory\n",
> - base, limit + PAGE_SIZE);
> + AMD_IOMMU_WARN("IVMD: [%lx,%lx) is not (entirely) in reserved memory\n",
> + base, limit + PAGE_SIZE);
>
> for ( addr = base; addr <= limit; addr += PAGE_SIZE )
> {
> @@ -423,7 +421,7 @@ static int __init parse_ivmd_block(const
> if ( e820_add_range(&e820, addr, addr + PAGE_SIZE,
> E820_RESERVED) )
> continue;
> - AMD_IOMMU_DEBUG("IVMD Error: Page at %lx couldn't be reserved\n",
> + AMD_IOMMU_ERROR("IVMD: page at %lx couldn't be reserved\n",
> addr);
> return -EIO;
> }
> @@ -433,8 +431,7 @@ static int __init parse_ivmd_block(const
> RAM_TYPE_UNUSABLE)) )
> continue;
>
> - AMD_IOMMU_DEBUG("IVMD Error: Page at %lx can't be converted\n",
> - addr);
> + AMD_IOMMU_ERROR("IVMD: page at %lx can't be converted\n", addr);
> return -EIO;
> }
> }
> @@ -448,7 +445,7 @@ static int __init parse_ivmd_block(const
> }
> else
> {
> - AMD_IOMMU_DEBUG("IVMD Error: Invalid Flag Field!\n");
> + AMD_IOMMU_ERROR("IVMD: invalid flag field\n");
> return -ENODEV;
> }
>
> @@ -471,7 +468,8 @@ static int __init parse_ivmd_block(const
> iw, ir, exclusion);
>
> default:
> - AMD_IOMMU_DEBUG("IVMD Error: Invalid Block Type!\n");
> + AMD_IOMMU_ERROR("IVMD: unknown block type %#x\n",
> + ivmd_block->header.type);
> return -ENODEV;
> }
> }
> @@ -481,7 +479,7 @@ static u16 __init parse_ivhd_device_padd
> {
> if ( header_length < (block_length + pad_length) )
> {
> - AMD_IOMMU_DEBUG("IVHD Error: Invalid Device_Entry Length!\n");
> + AMD_IOMMU_ERROR("IVHD: invalid Device_Entry length\n");
> return 0;
> }
>
> @@ -496,7 +494,7 @@ static u16 __init parse_ivhd_device_sele
> bdf = select->header.id;
> if ( bdf >= ivrs_bdf_entries )
> {
> - AMD_IOMMU_DEBUG("IVHD Error: Invalid Device_Entry Dev_Id %#x\n", bdf);
> + AMD_IOMMU_ERROR("IVHD: invalid Device_Entry Dev_Id %#x\n", bdf);
> return 0;
> }
>
> @@ -515,14 +513,13 @@ static u16 __init parse_ivhd_device_rang
> dev_length = sizeof(*range);
> if ( header_length < (block_length + dev_length) )
> {
> - AMD_IOMMU_DEBUG("IVHD Error: Invalid Device_Entry Length!\n");
> + AMD_IOMMU_ERROR("IVHD: invalid Device_Entry length\n");
> return 0;
> }
>
> if ( range->end.header.type != ACPI_IVRS_TYPE_END )
> {
> - AMD_IOMMU_DEBUG("IVHD Error: "
> - "Invalid Range: End_Type %#x\n",
> + AMD_IOMMU_ERROR("IVHD Error: invalid range: End_Type %#x\n",
NIT: I guess you want to drop the 'Error' here like you did elsewhere.
next prev parent reply other threads:[~2021-09-28 7:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 14:35 [PATCH v8 0/6] AMD/IOMMU: further work split from XSA-378 Jan Beulich
2021-09-22 14:36 ` [PATCH v8 1/6] AMD/IOMMU: obtain IVHD type to use earlier Jan Beulich
2021-09-28 7:12 ` Durrant, Paul
2021-10-19 23:34 ` Andrew Cooper
2021-10-20 6:58 ` Jan Beulich
2021-10-20 8:17 ` Jan Beulich
2021-09-22 14:37 ` [PATCH v8 2/6] AMD/IOMMU: improve (extended) feature detection Jan Beulich
2021-09-22 14:37 ` [PATCH v8 3/6] AMD/IOMMU: check IVMD ranges against host implementation limits Jan Beulich
2021-09-22 14:37 ` [PATCH v8 4/6] AMD/IOMMU: respect AtsDisabled device flag Jan Beulich
2021-09-28 7:34 ` Durrant, Paul
2021-09-28 7:47 ` Jan Beulich
2021-09-28 7:57 ` Durrant, Paul
2021-09-22 14:38 ` [PATCH v8 5/6] AMD/IOMMU: pull ATS disabling earlier Jan Beulich
2021-09-28 7:36 ` Durrant, Paul
2021-09-22 14:38 ` [PATCH v8 6/6] AMD/IOMMU: expose errors and warnings unconditionally Jan Beulich
2021-09-28 7:42 ` Durrant, Paul [this message]
2021-09-28 7:50 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9fe216-32a8-ef6d-173b-4f0d31a20db2@gmail.com \
--to=xadimgnik@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.