Backports Archive on lore.kernel.org
 help / color / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>, backports@vger.kernel.org
Cc: Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH 01/15] backports: handle RHEL 7.6 kernel
Date: Wed, 11 Mar 2020 10:38:31 +0100
Message-ID: <05b2f075407f4be8672a4325ed478a26296f856d.camel@sipsolutions.net> (raw)
In-Reply-To: <98e5b161-1bde-e663-d08a-6f142ab40aed@hauke-m.de>

On Sun, 2020-02-23 at 23:24 +0100, Hauke Mehrtens wrote:

> > +++ b/backport/backport-include/linux/time.h
> > @@ -1,5 +1,11 @@
> >  #ifndef __BACKPORT_LINUX_TIME_H
> >  #define __BACKPORT_LINUX_TIME_H
> > +
> > +#if RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,6)
> > +#include_next <linux/time64.h>
> > +#include <uapi/linux/time.h>
> > +#endif
> > +
> 
> Something is strange with the time header file handling.

Too many changes in this area, I guess ;-)

(I'd appreciate if you trimmed your quoting a bit, it's hard to find
your responses in the pages-long text)

> > +EXPORT_SYMBOL_GPL(get_user_pages_unlocked);
> > +#endif
> > +
> 
> Please check if this is needed at all.

I guess we can

> > -static struct scatterlist *scatterwalk_ffwd(struct scatterlist dst[2],
> > +#if RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(7,6)
> > + static struct scatterlist *scatterwalk_ffwd(struct scatterlist dst[2],
> 
> Why  did you add a space?

Heh.

> > @@ -441,3 +450,4 @@ int backport_genlmsg_multicast_allns(const struct genl_family *family,
> >  	return genlmsg_mcast(skb, portid, group, flags);
> >  }
> >  EXPORT_SYMBOL_GPL(backport_genlmsg_multicast_allns);
> > +#endif /* RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(7,6) */
> 
> Please check again if all these ifdefs for redhat are needed in this
> function. It looks like there are some bigger ifdes around most of the
> code in here.

This stuff is very tricky, and they tend to backport pieces of it ...

johannes

--
To unsubscribe from this list: send the line "unsubscribe backports" in

  parent reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21  8:56 [PATCH 00/15] updates & improvements Johannes Berg
2020-02-21  8:56 ` [PATCH 01/15] backports: handle RHEL 7.6 kernel Johannes Berg
2020-02-23 22:24   ` Hauke Mehrtens
2020-02-24  8:40     ` Johannes Berg
2020-02-24 22:47       ` Hauke Mehrtens
2020-03-11  9:38     ` Johannes Berg [this message]
2020-02-21  8:56 ` [PATCH 02/15] backports: update x509.asn1.[ch] Johannes Berg
2020-02-23 22:26   ` Hauke Mehrtens
2020-02-24  8:39     ` Johannes Berg
2020-02-21  8:56 ` [PATCH 03/15] backports: suppress attribute((cold)) warnings with gcc 9 Johannes Berg
2020-02-21  8:56 ` [PATCH 04/15] backports: add some more atomic functions Johannes Berg
2020-02-21  8:56 ` [PATCH 05/15] backports: Do not access rx_count and rx_list attributes Johannes Berg
2020-02-21  8:56 ` [PATCH 06/15] backports: if_vlan: add VLAN_N_VID Johannes Berg
2020-02-21  8:56 ` [PATCH 07/15] patches: make nl80211.c include if_vlan.h Johannes Berg
2020-02-23 22:28   ` Hauke Mehrtens
2020-02-21  8:56 ` [PATCH 08/15] gentree: add timing info to git debug commit message Johannes Berg
2020-02-21  8:56 ` [PATCH 09/15] backports: debugfs: add unsigned long helpers Johannes Berg
2020-02-21  8:56 ` [PATCH 10/15] backports: patch lib/refcount.c to make sparse happy Johannes Berg
2020-02-21  8:56 ` [PATCH 11/15] gentree: add a --list-files option Johannes Berg
2020-02-21  8:56 ` [PATCH 12/15] git-tracker: use python2 explicitly Johannes Berg
2020-02-21  8:56 ` [PATCH 13/15] git-tracker: use write-tree/commit-tree/update-ref Johannes Berg
2020-02-21  8:56 ` [PATCH 14/15] git-tracker: refactor function that adds change-id Johannes Berg
2020-02-21  8:56 ` [PATCH 15/15] gentree: use 'git cat-file' to speed up obtaining objects Johannes Berg
2020-03-24 23:11 ` [PATCH 00/15] updates & improvements Hauke Mehrtens
2020-03-25  7:59   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b2f075407f4be8672a4325ed478a26296f856d.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=backports@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Backports Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/backports/0 backports/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 backports backports/ https://lore.kernel.org/backports \
		backports@vger.kernel.org
	public-inbox-index backports

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.backports


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git