Backports Archive on lore.kernel.org
 help / Atom feed
* [PATCH v2] backports: add header file for function memcmp
@ 2018-08-22  3:06 Winnie Chang
  2018-08-22  7:18 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Winnie Chang @ 2018-08-22  3:06 UTC (permalink / raw)
  To: backports; +Cc: Chi-Hsien.Lin

Function memcmp is implicit declaration on kernel 4.9.88 ARM platform.
backport-include/keys/asymmetric-type.h uses function memcmp but its
caller compat/verification/verify.c and all its related header files
do not include string.h. The header file is usually included from
arch/arm/include/asm, but in this configuration, it doesn't. We need
to be safe and insure string.h is there.

Signed-off-by: Winnie Chang <winnie.chang@cypress.com>
---
 backport/backport-include/keys/asymmetric-type.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/backport/backport-include/keys/asymmetric-type.h b/backport/backport-include/keys/asymmetric-type.h
index ee9c418..5744de9 100644
--- a/backport/backport-include/keys/asymmetric-type.h
+++ b/backport/backport-include/keys/asymmetric-type.h
@@ -2,6 +2,8 @@
 #define __BP_ASYMMETRIC_TYPE_H
 #ifdef CPTCFG_BPAUTO_BUILD_SYSTEM_DATA_VERIFICATION
 
+#include <linux/string.h>
+
 struct asymmetric_key_id {
 	unsigned short	len;
 	unsigned char	data[];
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe backports" in

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] backports: add header file for function memcmp
  2018-08-22  3:06 [PATCH v2] backports: add header file for function memcmp Winnie Chang
@ 2018-08-22  7:18 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2018-08-22  7:18 UTC (permalink / raw)
  To: Winnie Chang, backports; +Cc: Chi-Hsien.Lin

On Tue, 2018-08-21 at 22:06 -0500, Winnie Chang wrote:
> Function memcmp is implicit declaration on kernel 4.9.88 ARM platform.
> backport-include/keys/asymmetric-type.h uses function memcmp but its
> caller compat/verification/verify.c and all its related header files
> do not include string.h. The header file is usually included from
> arch/arm/include/asm, but in this configuration, it doesn't. We need
> to be safe and insure string.h is there.

Makes sense, thanks!

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22  3:06 [PATCH v2] backports: add header file for function memcmp Winnie Chang
2018-08-22  7:18 ` Johannes Berg

Backports Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/backports/0 backports/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 backports backports/ https://lore.kernel.org/backports \
		backports@vger.kernel.org backports@archiver.kernel.org
	public-inbox-index backports


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.backports


AGPL code for this site: git clone https://public-inbox.org/ public-inbox